-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Release Package Publication #5963
Merged
kodiakhq
merged 47 commits into
Azure:release/1.2
from
nimanch:personal/nimanch/automatepublish
Jan 7, 2022
Merged
Automate Release Package Publication #5963
kodiakhq
merged 47 commits into
Azure:release/1.2
from
nimanch:personal/nimanch/automatepublish
Jan 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR Re-enables Rust Coverage in Check in Pipelines 1. Remove the Dependency to on nightly build on Rust. Use the same version of rust as other pipelines 2. Use Cargo Tarpaulin for Create Code Coverage Reports. This was recommended by other teams within Microsoft developing rust code. (https://lib.rs/crates/cargo-tarpaulin) 3. Publish HTML Code Coverage Report Based on Coverage Report Note : The Current Code Coverage stands at 44%. I had to reduce the code coverage gate for Rust to 44%. The intent is to increase the code coverage and then increase the gate. Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab
nimanch
changed the title
Automate Publication of Release Packages
Automation Release Package Publication
Jan 7, 2022
…/nimanch/iotedge into personal/nimanch/automatepublish
damonbarry
reviewed
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll hold off on approving though, since it will get reset anyway when you uncomment stuff after testing.
Thanks!, I have done by testing and uncomment the publish part out. |
damonbarry
approved these changes
Jan 7, 2022
nimanch
changed the title
Automation Release Package Publication
Automate Release Package Publication
Jan 7, 2022
darobs
approved these changes
Jan 7, 2022
This was referenced Jan 14, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
This PR Manually Ports over changes from 1. #5983 2. #5963 Waiting for this Test Run to pass 1. https://dev.azure.com/msazure/One/_build/results?buildId=50830892&view=results ## Azure IoT Edge PR checklist:
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
This PR brings changes from 1. #5963 2. #5983 to release/1.1. Manual Changes had to be done due to significant difference in how packages are build in 1.2 vs 1.1. This PR is a follow up of 1. #5995 Testing 1. Hardcoded Version and Branch and verified that Packages are uploaded to Github : https://dev.azure.com/msazure/One/_build/results?buildId=50827929&view=results 2. Verified Can run repo client tool and query status: https://dev.azure.com/msazure/One/_build/results?buildId=50830155&view=results ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
lt72
pushed a commit
to lt72/iotedge
that referenced
this pull request
Jan 31, 2022
This PR Manually Ports over changes from 1. Azure#5983 2. Azure#5963 Waiting for this Test Run to pass 1. https://dev.azure.com/msazure/One/_build/results?buildId=50830892&view=results ## Azure IoT Edge PR checklist:
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
This PR Manually Ports over changes from 1. Azure#5983 2. Azure#5963 Waiting for this Test Run to pass 1. https://dev.azure.com/msazure/One/_build/results?buildId=50830892&view=results ## Azure IoT Edge PR checklist:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR Adds
a. Downloads Docker Image for making API Calls to Microsoft Packaging Service
b. Pushes the Packages
c. Checks the Status of Upload
a. Waits for Approval before beginning Publish
b. Downloads Artifacts from Current Build
c. Download IIS Artifact from Corresponding IIS Commit
d. Run the Above Script
Testing
TODO
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draft
mode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description