Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push and build for layered deployments #494

Merged

Conversation

EliiseS
Copy link
Collaborator

@EliiseS EliiseS commented Aug 11, 2021

iotedgedev Pull Request Checklist

  • Versions updated (both init.py files, CHANGELOG, setup.py, setup.cfg)
  • Unit tests pass locally
  • Quickstart steps locally validated
  • Passes unit tests in CICD pipeline (green on Github pipeline)
  • Pypi RC version passes Edge CICD pipeline validation for cross-tool validation

Additional comments

Part of #430, but not the full solution. (Don't close the issue with this PR)

This PR covers:

Layered deployment template reference: https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/iot-edge/how-to-deploy-cli-at-scale.md#configure-a-deployment-manifest

Layered deployment with no modules: Azure/iotedge#5299

@EliiseS EliiseS force-pushed the feature/add-layered-deployment-build-push branch from 29b3d7b to 04c0d3e Compare August 11, 2021 11:34
setup.py Show resolved Hide resolved
.env.tmp Outdated
@@ -31,6 +31,7 @@ CONTAINER_REGISTRY_PASSWORD=""
#

EDGE_RUNTIME_VERSION="1.0"
LAYERED_RUNTIME_TAG="1.0"
Copy link
Collaborator

@marianan marianan Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LAYERED_RUNTIME_TAG

Should this be a boolean flag instead of integer version? Also, I would assume the default value should be false? #Resolved

Copy link
Collaborator Author

@EliiseS EliiseS Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed my mind three times on what to do with this and I've landed on that I've removed this completely and just determine if it's a layered deployment schema by looking for the content key in the top level.

This allows this PR to be as self standing as it can be, since the idea I have for this is to just enable creating config from layered deployment templates and build/push those any images.

Copy link
Collaborator

@marianan marianan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Collaborator

@marianan marianan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@EliiseS EliiseS force-pushed the feature/add-layered-deployment-build-push branch from 0b5a73a to b55a9ae Compare August 16, 2021 15:56
@EliiseS EliiseS force-pushed the feature/add-layered-deployment-build-push branch 2 times, most recently from c426095 to 4a09ca6 Compare August 18, 2021 16:42
@EliiseS EliiseS force-pushed the feature/add-layered-deployment-build-push branch from 4a09ca6 to 0941e94 Compare August 18, 2021 18:42
@marianan marianan merged commit 2de17d2 into Azure:master Aug 18, 2021
@EliiseS EliiseS deleted the feature/add-layered-deployment-build-push branch September 6, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants