-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add push and build for layered deployments #494
Add push and build for layered deployments #494
Conversation
29b3d7b
to
04c0d3e
Compare
…ed-deployment-build-push
.env.tmp
Outdated
@@ -31,6 +31,7 @@ CONTAINER_REGISTRY_PASSWORD="" | |||
# | |||
|
|||
EDGE_RUNTIME_VERSION="1.0" | |||
LAYERED_RUNTIME_TAG="1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed my mind three times on what to do with this and I've landed on that I've removed this completely and just determine if it's a layered deployment schema by looking for the content
key in the top level.
This allows this PR to be as self standing as it can be, since the idea I have for this is to just enable creating config from layered deployment templates and build/push those any images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0b5a73a
to
b55a9ae
Compare
c426095
to
4a09ca6
Compare
4a09ca6
to
0941e94
Compare
iotedgedev Pull Request Checklist
Additional comments
Part of #430, but not the full solution. (Don't close the issue with this PR)
This PR covers:
Layered deployment with no modules: Azure/iotedge#5299