Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Only monitor events for a valid device ID (#30) #33

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

damonbarry
Copy link
Member

Reference/Link to the issue solved with this PR (if any)

Solves #30

Description of the problem

iothub-explorer will happily monitor events for a device that doesn't exist:

$ iothub-explorer monitor-events i-do-not-exist -l "{connection-string}"

Monitoring events from device i-do-not-exist...

Description of the solution

Now the monitor-events command checks that the device exists before setting up the event monitor. If it does not exist, the command fails:

$ iothub-explorer monitor-events i-do-not-exist -l "{connection-string}"

Error: DeviceNotFoundError: i-do-not-exist

Copy link
Contributor

@pierreca pierreca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@az-iot-builder-01 az-iot-builder-01 merged commit ff43855 into Azure:master Nov 29, 2017
@damonbarry damonbarry deleted the validate-device-id branch November 29, 2017 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants