-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Update k8s-bake version on examples #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! Thanks for this PR. Would you update the example version to be v2.2 as that is the latest? |
Okay, updated to v2.2 04492bf |
OliverMKing
approved these changes
Apr 18, 2022
davidgamero
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
OliverMKing
added a commit
that referenced
this pull request
Oct 3, 2022
* Add support for Linux-arm64 * add release workflow (#46) * master to main rename (#48) * Updated workflows, codeowner, .gitignore, tsconfig (#49) * Updated workflows, codeowner, .gitignore, tsconfig * Fixing test discrepancies * Fixing paths * Fixing paths * fixing int tests * Fixing int test * Fixing int test * Helm namespace feature (#51) * switch to index.js (#53) * Bump minimist from 1.2.5 to 1.2.6 (#58) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * README: Update k8s-bake version on examples (#60) * README: Update k8s-bake version on examples * README: Update example version to v2.2 * modified template arguments (#61) * modified templete arguments * updated template arguments * updated unit tests for multiple arguments * updated the unit test * added multiple arguments for kustomize * get template args code changes * updated the shared template arg function * clean code * bug fixes in unit tests * updated the readme, action and added the namespace in run.ts * updated the template argument method * modified kustomizeRenderEngine Co-authored-by: Vidya Reddy <vidyareddy@microsoft.com> * Vidya reddy/prettier code (#62) * Vidya reddy - prettier code and adding vercel/ncc build to build script (#63) * modified templete arguments * updated template arguments * updated unit tests for multiple arguments * updated the unit test * added multiple arguments for kustomize * get template args code changes * updated the shared template arg function * clean code * bug fixes in unit tests * updated the readme, action and added the namespace in run.ts * updated the template argument method * modified kustomizeRenderEngine * Enforce prettify * Run prettier * updated the template args method * updated the template args * updated the temp argument func * Add ncc build to build script Co-authored-by: Vidya Reddy <vidyareddy@microsoft.com> * Update README.md (#64) * Add node modules and compiled JavaScript from main Co-authored-by: Christophe Sauthier <christophe.sauthier@objectif-libre.com> Co-authored-by: Oliver King <kingoliver@microsoft.com> Co-authored-by: David Gamero <david340804@gmail.com> Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com> Co-authored-by: Oliver King <oking3@uncc.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: nonylene <nonylene@gmail.com> Co-authored-by: Vidya Reddy <59590642+Vidya2606@users.noreply.github.com> Co-authored-by: Vidya Reddy <vidyareddy@microsoft.com> Co-authored-by: Jaiveer Katariya <35347859+jaiveerk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.x is the current latest version of k8s-bake.
Follow-up of #59