test(e2e): fix indentation for dump logs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 10, 2023 11:48
tallaxes
approved these changes
Nov 10, 2023
|
Completing without getting the E2E tests to pass as this change should not non-impactful on the actual suites, and verified the fix to the flow works as desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
@tallaxes noticed that the log dump on failure was not working.
Looking into it I noticed that the action was not indented correctly. This PR fixes the indentation, and the issues with the log dump.
How was this change tested?
I ran the E2E pipeline with a guaranteed failure [in drift] with the log dumps current status in main, which caused it to fail:
https://github.com/Azure/karpenter/actions/runs/6829122309/job/18574667354
Then I ran it with the guaranteed failure [in drift] with the log dump indentation fixed:
https://github.com/Azure/karpenter/actions/runs/6829114912
The fixed indentation executed correctly.
*
Does this change impact docs?
Release Note