Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): remove wait on gatekeeper #27

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

charliedmcb
Copy link
Collaborator

@charliedmcb charliedmcb commented Nov 11, 2023

Fixes #

Description
This wait was in place when we had a taint added that stopped any new pods from provisioning on the system nodes.

However, we switched to CriticalAddonsOnly which the gatekeeper pods have a Toleration for:
image

So should be able to remove this and speed up the cluster creation process.

How was this change tested?
Ran the e2e pipeline 5 times and didn't spot anything obviously an issue from gatekeeper.
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator Author

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@charliedmcb charliedmcb marked this pull request as ready for review November 13, 2023 19:55
@charliedmcb charliedmcb merged commit 057ac97 into main Nov 13, 2023
11 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/removeGatekeeperWait branch November 13, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants