Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added verbose logging in convert-kubeconfig #272

Merged
merged 3 commits into from
May 4, 2023

Conversation

weinong
Copy link
Contributor

@weinong weinong commented May 2, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #272 (b8af9c5) into master (4f9ad34) will increase coverage by 0.35%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   50.18%   50.53%   +0.35%     
==========================================
  Files          15       15              
  Lines        1100     1120      +20     
==========================================
+ Hits          552      566      +14     
- Misses        517      522       +5     
- Partials       31       32       +1     
Impacted Files Coverage Δ
pkg/converter/convert.go 78.87% <66.66%> (-0.83%) ⬇️
pkg/converter/options.go 100.00% <100.00%> (ø)

Copy link
Member

@bcho bcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

pkg/converter/convert.go Show resolved Hide resolved
@weinong weinong enabled auto-merge (squash) May 4, 2023 08:03
@weinong weinong merged commit 48d3b6f into Azure:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants