Add PoP token support for ROPC flow #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add VCR tests for ROPC flow Fix formatting issues Add VCR tests for ROPC flow
rharpavat
force-pushed
the
add-pop-token-support-to-ropc-flow
branch
from
732ee53 to
9b2754c
Compare
julienstroheker
suggested changes
Feb 20, 2024
pkg/internal/token/testdata/ROPCPoPTokenFromBadPasswordVCR.yaml
Outdated
Show resolved
Hide resolved
pkg/internal/token/testdata/ROPCPoPTokenFromBadPasswordVCR.yaml
Outdated
Show resolved
Hide resolved
pkg/internal/token/testdata/ROPCPoPTokenFromUsernamePasswordVCR.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 64.34% 65.98% +1.64%
==========================================
Files 28 29 +1
Lines 1949 2046 +97
==========================================
+ Hits 1254 1350 +96
- Misses 620 624 +4
+ Partials 75 72 -3 ☔ View full report in Codecov by Sentry. |
added 2 commits
February 21, 2024 21:53
julienstroheker
approved these changes
Feb 22, 2024
weinong
reviewed
Feb 22, 2024
weinong
reviewed
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds PoP token support for ROPC login flow in order to enable using ROPC flow for automated testing of 1P AzRBAC scenarios.
Currently, automated testing for AzRBAC and PoP token flow relies on SPN login, which uses the msal
confidentialclient. However, most customers will be using the interactive login flow which uses msal'spublicclient. In order to enable better testing of the customer scenario, this change enables PoP token support for username/password flow so that automated testing can be conducted for the public client.MSAL PR to make this change: AzureAD/microsoft-authentication-library-for-go#472
This PR vendors the latest MSAL release containing the change: https://github.com/AzureAD/microsoft-authentication-library-for-go/releases/tag/v1.2.2