Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AZURE_CONFIG_DIR in kubelogin command example #522

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

tspearconquest
Copy link
Contributor

When calling kubelogin with AZURE_CONFIG_DIR already set in a Jenkins job, just use that variable on the command line for consistency with the variable Jenkins is using, instead of doing $WORKSPACE/.azure which might not be where AZURE_CONFIG_DIR points to.

When calling `kubelogin` with `AZURE_CONFIG_DIR` already set in a Jenkins job, just use that variable on the command line for consistency with the variable Jenkins is using, instead of doing `$WORKSPACE/.azure` which might not be where AZURE_CONFIG_DIR points to.
Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit 22d3285 into Azure:main Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants