Improve shell completion for convert-config #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to improve shell completion of
kubelogin
.I started with a command and option that I use frequently:
kubelogin convert-config --login
.What I did
I found it hard to spot a place where the code naturally fits.
I decided to put it beside the
AddFlags
methods so that I can access non-exported variables (supportedLogin
)and do not conflict with existing tests.
The structure is intended to be open for further additions.
Please let me know if this is a good way to go before I add more completions.
How to verify
Import bash completion for kubelogin:
Without this PR:
kubelogin convert-config <TAB><TAB>
=> completion of filenames (wrong)kubelogin convert-config --login <TAB><TAB>
=> completion of filenames (wrong)With this PR:
kubelogin convert-config <TAB><TAB>
=> no completionkubelogin convert-config --login <TAB><TAB>
=> completion of supported logins