feat: pass ctx into tool calls #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gossion
commented
Dec 15, 2025
| args["_tool_name"] = toolName | ||
|
|
||
| result, err := executor.Execute(args, cfg) | ||
| result, err := executor.Execute(ctx, args, cfg) |
Member
Author
There was a problem hiding this comment.
for reviewer: the major purpose is to make the tools be aware of this ctx.
Member
Author
There was a problem hiding this comment.
it can be used for "context-aware operations, such as cancellation and timeouts", will add ctx control later if needed.
Fei-Guo
approved these changes
Dec 15, 2025
mainred
approved these changes
Dec 15, 2025
| args["_tool_name"] = toolName | ||
|
|
||
| result, err := executor.Execute(args, cfg) | ||
| result, err := executor.Execute(ctx, args, cfg) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the command execution interface across multiple tool executors to accept a
context.Contextparameter. This change ensures that all command executions can support context-aware operations, such as cancellation and timeouts, and improves consistency across the codebase. The update affects the interface, all executor implementations, and their usages in handlers and tests.