Remove default NSG rules for 22 and 3389 from Bicep deployment (#538)

* Modify NSG in hub Resource Group #443 * GitHub Action: Build Bicep to JSON Co-authored-by: github-actions <github-actions@github.com>
Azure · Nov 19, 2021 · 6b6e740 · 6b6e740
1 parent d2cafe3
commit 6b6e740
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 60 deletions.
diff --git a/src/bicep/mlz.bicep b/src/bicep/mlz.bicep
@@ -325,36 +325,7 @@ param hubSubnetAddressPrefix string = '10.0.100.128/27'
 param hubVirtualNetworkDiagnosticsLogs array = []
 param hubVirtualNetworkDiagnosticsMetrics array = []
 param hubNetworkSecurityGroupName string = 'hub-nsg'
-param hubNetworkSecurityGroupRules array = [
- {
- name: 'allow_ssh'
- properties: {
- description: 'Allow SSH access from anywhere'
- access: 'Allow'
- priority: 100
- protocol: 'Tcp'
- direction: 'Inbound'
- sourcePortRange: '*'
- sourceAddressPrefix: '*'
- destinationPortRange: '22'
- destinationAddressPrefix: '*'
- }
- }
- {
- name: 'allow_rdp'
- properties: {
- description: 'Allow RDP access from anywhere'
- access: 'Allow'
- priority: 200
- protocol: 'Tcp'
- direction: 'Inbound'
- sourcePortRange: '*'
- sourceAddressPrefix: '*'
- destinationPortRange: '3389'
- destinationAddressPrefix: '*'
- }
- }
-]
+param hubNetworkSecurityGroupRules array = []
 param hubNetworkSecurityGroupDiagnosticsLogs array = [
  {
  category: 'NetworkSecurityGroupEvent'

diff --git a/src/bicep/mlz.json b/src/bicep/mlz.json
@@ -80,36 +80,7 @@
  },
  "hubNetworkSecurityGroupRules": {
  "type": "array",
- "defaultValue": [
- {
- "name": "allow_ssh",
- "properties": {
- "description": "Allow SSH access from anywhere",
- "access": "Allow",
- "priority": 100,
- "protocol": "Tcp",
- "direction": "Inbound",
- "sourcePortRange": "*",
- "sourceAddressPrefix": "*",
- "destinationPortRange": "22",
- "destinationAddressPrefix": "*"
- }
- },
- {
- "name": "allow_rdp",
- "properties": {
- "description": "Allow RDP access from anywhere",
- "access": "Allow",
- "priority": 200,
- "protocol": "Tcp",
- "direction": "Inbound",
- "sourcePortRange": "*",
- "sourceAddressPrefix": "*",
- "destinationPortRange": "3389",
- "destinationAddressPrefix": "*"
- }
- }
- ]
+ "defaultValue": []
  },
  "hubNetworkSecurityGroupDiagnosticsLogs": {
  "type": "array",