-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove providers #84
Remove providers #84
Conversation
Note: the container definition does not modify permissions of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Everything worked as expected. Since you're out today I'm going to merge these changes.
* add the shellcheck extension to the devcontainer (#70) Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * Enable Azure Security Center in MLZ subscriptions (#55) * Updated documentation in script * - Added execution flag to shell scripts - Added configure_asc.sh script - Added code to create subs array to mlz_tf_setup.sh - Added code to call configure_asc.sh from mlz_tf_setup.sh * - Added executable flag to unzipprovider.sh script * - Added executable flag to check scripts * - Updated loop code for workspace setting * - Created folder for ASC scripts - Copied generate_names.sh script into ASC folder * - Removed ASC calling code from setup script - Updated naming in asc script - Added ASC naming to generate script * - Moved LAWS name generation into generate names - Moved generate names call into loop - Updated wait loop to use variables * - Removed message for elapsed time - Added quotes consistently for echo's * - Updated Copyright statement - Added set -e - Modified variables to use env & location from vars file * - Corrected counter logic - Corrected description in names script * output number of attempts remaining * add a comment that this may fail * - Removed creater comment * unusually typo Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * Add persona and business justification to the Issue template (#73) * issue template update * Implement error handling into shell scripts (#72) * - Added error handling to configure_asc script - Suppressed "create" output in configure_asc script * - Added error handling to config_create script - Remove commented lines from configure_asc script * - Added error handling to config_validate script * - Added error handling to get_sp_identity script - Corrected SP lookup * - Added error handling to mlz_config_create script * - Updated echo lines * Implement Sub ID array for Role assignment (#76) * - Updated bullet numbering in README - Added code to create sub id array * - Reverted numbering changes made to README.md * - Added description of sed command * - Added parameter to suppress WARNING on sp create * Remove providers (#84) * use azurerm 2.50 in src/core * removing provider files * updates to readme and scripts for local providers * set tf provider folder Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * unique diagnostic settings names (#82) Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * move scripts to src/scripts (#87) * add a workflow for apply and destroy terraform (#83) * add retries for apply and destroy * update readmes Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com> Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> Co-authored-by: Byron Boudreaux <16844071+Phydeauxman@users.noreply.github.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Co-authored-by: Breanna-Stryker <>
Description
Issue reference
The issue this PR will close: #61
Checklist
shellcheck
.vscode/extensions.json
.)