Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completion items exclude matches on parameter names #455

Merged
merged 2 commits into from
May 21, 2024
Merged

completion items exclude matches on parameter names #455

merged 2 commits into from
May 21, 2024

Conversation

morgilad
Copy link
Collaborator

@morgilad morgilad commented May 19, 2024 •
edited
Loading

chore: completion items exclude parameters.

work item

  • use match text as the filter text - which exclude the parameters names
  • filter completion items gracefully - meaning when the search term is "ago" results with "aog" will not appear
  • improve vite local env and design

@morgilad morgilad requested review from sagivf and maxburs May 19, 2024 06:47
@morgilad morgilad merged commit fa22437 into master May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxburs maxburs maxburs left review comments

@sagivf sagivf Awaiting requested review from sagivf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morgilad @maxburs