-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Scalar parameter docstring and example arguments unused #479
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
947d3be
fix: Parameter docstring and example arguments unused
maxburs d96e515
Merge branch 'master' of https://github.com/Azure/monaco-kusto into u…
maxburs a3c3691
Added tests
maxburs 573a0b6
Bump package version
maxburs fc9eeb2
Fixed failing test
maxburs 3660229
Increase timeout
maxburs a47dbd8
Upload playwright report
maxburs 5e4eaa6
Where's my report?
maxburs e9769d0
Ok, thats why
maxburs 84f12f5
Retain more traces
maxburs ce5c360
Woops
maxburs 1959be9
Remove snapshots
maxburs 76b990a
Likely wont work
maxburs 2da5447
Try something else
maxburs 9e84799
Cleanup diff and try adding timeout
maxburs e2e83e7
Ugggg
maxburs 9fc9afa
Revert
maxburs 41ec976
Tweak
maxburs b4025eb
Try revert
maxburs fc684e3
Cleanup
maxburs 43bc6f3
Revert more stuff
maxburs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this change, others are a bit more speculative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear on the use case.
Could we add a unit or integration test to clarify it and help prevent regressions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples and docstring/description are added to tooltips on hover. I'm using them for dashboard system parameters, and and I'd assume other ones are in the system we get from kusto (otherwise, IDK why the C# api would expose it)
Unlike a lot of other stuff, this isn't really load bearing. If it breaks it won't block a release. I don't think it should be a priority for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a unit test would help I might add that, because it would be easy, but I don't think it would do anything useful.
An integration tests would be pretty expensive to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry if I wasn't clear.
From my perspective, testing is an important part of our work as engineers.
It helps ensure that what we build remains reliable and understandable for other developers.
I would suggest adding an integration test here, but if that's too difficult, a unit test would also be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxburs can you add some examples/screenshots of where this shows up and how?
That would help in understanding how/what test we should add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.