Add exports to several request policy factory methods #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are useful when customizing the requestPolicyFactories array of a ServiceClientOptions instance.
ghost
added
the
|
LGTM. @daschult, what do you think? |
ghost
approved these changes
Mar 19, 2019
|
@jeremymeng, do you mind updating the version in package.json to 1.8.0? I can't push to your fork. After that it's good to go. |
kpajdzik
approved these changes
Mar 19, 2019
|
Version updated. Thank all for reviewing! |
|
@jeremymeng I forgot about version from Constants.ts (https://github.com/Azure/ms-rest-js/blob/master/lib/util/constants.ts#L11). If you could update that as well, I'd appreciate a lot :) Sorry for missing that! |
jeremymeng
force-pushed
the
export-request-policy-factories
branch
from
36422bf
to
e6805d0
Compare
|
@kpajdzik no problem! |
|
@jeremymeng, This should be published in the next hour. Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are useful when customizing the requestPolicyFactories array of a
ServiceClientOptions instance.
Resolves #334.