Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node-fetch require for webpack #376

Merged
merged 5 commits into from
Jan 8, 2020
Merged

Fix node-fetch require for webpack #376

merged 5 commits into from
Jan 8, 2020

Conversation

AnthonyMacKinnon
Copy link
Contributor

fixes #373

We ran into the same issue as @christiango when using webpack for a server-side node project.

daviwil
daviwil approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on getting this reviewed and merged! I'll try to kick the build to see if I can get it to go green.

@daviwil
Copy link
Contributor

daviwil commented Jan 8, 2020

The autorest.typescript dependent test failure needs changes to the Azure DevOps scripts (following on from work done in the 1.x branch). I'll do that in a separate PR. Merging this now, thanks @AnthonyMacKinnon!

@daviwil daviwil merged commit 6244e91 into Azure:master Jan 8, 2020
@daviwil daviwil mentioned this pull request Jan 8, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil approved these changes

@sergey-shandar sergey-shandar Awaiting requested review from sergey-shandar

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpacking ms-rest-js results in TypeError: fetch is not a function
2 participants
@AnthonyMacKinnon @daviwil