Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade uuid dependency to v8 #456

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Upgrade uuid dependency to v8 #456

merged 3 commits into from
Jul 12, 2021

Conversation

deyaaeldeen
Copy link
Member

From #455:

Currently, installing @azure/ms-rest-js@latest, produces the following message:

deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

So this PR upgrades dep on uuid to latest version. Fixes #455

@deyaaeldeen deyaaeldeen requested a review from xirzec as a code owner July 12, 2021 19:46
@deyaaeldeen deyaaeldeen mentioned this pull request Jul 12, 2021
Closed
jeremymeng
jeremymeng approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing it!

@deyaaeldeen deyaaeldeen merged commit 7020888 into master Jul 12, 2021
@deyaaeldeen deyaaeldeen deleted the upgrade-uuid branch July 12, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security vulnerability for uuid@3.x.x
2 participants
@deyaaeldeen @jeremymeng