-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix x-ms-enum as discriminator #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a comment, please refer the issue on type change for jsonRefs
@sergey-shandar could you expand on your resolution for my question/comment: "there are cases were this should be true, like on enums not part of discriminator types, how are we affecting those cases? we generally recommend modelAsString= true for specs, to avoid breaking changes in future api-versions for code generation, so I'd like to understand more of what's not working due to this value for the tool" |
@veronicagg this fix is only applied for a specific model (internally generated) when we know exact value that we expect. oav/lib/validators/specResolver.ts Line 950 in d5bfd41
Honestly, |
Issue #325