Merge branch 'main' into better-conditions

Azure · Jun 14, 2021 · b905adb · b905adb
2 parents 9f69894 + c0f319c
commit b905adb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/controllers/appgroup_controller_test.go b/controllers/appgroup_controller_test.go
@@ -148,7 +148,7 @@ var _ = Describe("ApplicationGroup Controller", func() {
 				if readyCondition == nil {
 					return false
 				}
-				return readyCondition.Reason == meta.FailedReason
+				return readyCondition.Reason == meta.ChartPullFailedReason
 			}, time.Second*30, time.Second).Should(BeTrue())
 		})
 
@@ -223,7 +223,7 @@ var _ = Describe("ApplicationGroup Controller", func() {
 				if readyCondition == nil {
 					return false
 				}
-				return readyCondition.Reason == meta.FailedReason
+				return readyCondition.Reason == meta.ChartPullFailedReason
 			}, time.Second*30, time.Second).Should(BeTrue())
 
 			patch := client.MergeFrom(applicationGroup.DeepCopy())
@@ -299,7 +299,7 @@ var _ = Describe("ApplicationGroup Controller", func() {
 			}, DefaultTimeout, time.Second).Should(BeTrue())
 		})
 
-		FIt("should succeed to rollback helm chart versions on failure", func() {
+		It("should succeed to rollback helm chart versions on failure", func() {
 			applicationGroup := defaultAppGroup(name)
 			applicationGroup.Namespace = DefaultNamespace
 			applicationGroup.Spec.Applications[1].Spec.Chart.Version = ambassadorOldChartVersion

diff --git a/examples/simple/bookinfo.yaml b/examples/simple/bookinfo.yaml
@@ -8,7 +8,7 @@ spec:
       dependencies: []
       spec:
         chart:
-          url: "https://www.getambassador.io/helm"
+          url: "https://nitishm.github.io/charts"
           name: ambassador 
           version: 6.6.0
           # Authorization Object Reference (Kind: Secret)