This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts tested and working fine. The only issue I noticed is a missing "testing" tag in the docker-compose when deploying the branch with CLI, unrelated to this PR |
dluc
changed the title
Fix Device Simulation setup script
DON'T MERGE - Fix Device Simulation setup script
Nov 15, 2018
hathind-ms
reviewed
Nov 15, 2018
ppathan
reviewed
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these improvements be applied to RM as well? I'm talking in addition to setupwrapper changes
hathind-ms
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment on te
hathind-ms
changed the title
DON'T MERGE - Fix Device Simulation setup script
Fix Device Simulation setup script
Nov 15, 2018
@ppathan yes, these 2 PRs contain improvements/fixes that we should apply to other solutions:
Note that the setup now creates a log file under |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Change type
Checklist:
This change is