Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add pipeline variables #11

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

ionutleca
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Jan 7, 2020

CLA assistant check
All CLA requirements met.

@ionutleca ionutleca closed this Jan 7, 2020
@ionutleca ionutleca reopened this Jan 7, 2020
.gitignore Outdated Show resolved Hide resolved
@anweiss
Copy link

anweiss commented Feb 12, 2020

@nishubansal @N-Usha this is a much needed feature for this Action. Can we get this reviewed and merged in once the node_modules/ dir is removed from this PR?

Copy link

@anweiss anweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... @nishubansal @N-Usha for final review and merging

@msoute
Copy link

msoute commented Apr 23, 2020

@ionutleca is there any progress on the PR ? This feature would be very usefull

@mfcollins3
Copy link

So it looks like this PR is stuck in limbo. Is there some other way of getting this functionality into here? Being able to set the values of pipeline variables is really important. Can the core team just implement the functionality without using this PR? Or can I submit a PR with a similar code to get this moving?

@ionutleca
Copy link
Contributor Author

I will try to get my current employer approval for the CLA required for this PR. If I find out that it takes more than 24h, I'll let you know if you should just create the PR with these changes yourself, @mfcollins3.

@mfcollins3
Copy link

Thanks, @ionutleca. I greatly appreciate you getting the CLA approved. I can't wait to start using this!

@FlipABit
Copy link

@ionutleca I'm assuming since 24h turned into 2+ months, one of us can go ahead and create the PR with these changes ourselves?

@ionutleca
Copy link
Contributor Author

The CLA was approved a long time ago.

@bm77525-kr
Copy link

Apologies, the timeline was a bit confusing. It’s a shame because this is super useful, but they seemed to let it fall by the wayside.

@ionutleca
Copy link
Contributor Author

No worries. It seems useful to me as well, but we might be the only ones :))

@bm77525-kr
Copy link

@nishubansal @N-Usha @anweiss Can anyone finally get this merged in?

@utricularia
Copy link

Any chance either this or the PR for adding build parameters might get merged in?

@JamesBurnside
Copy link
Member

+1 to getting this merged in

@ionutleca ionutleca force-pushed the feature/add-pipeline-variables branch from b4d74ec to e6014dc Compare June 3, 2021 08:12
@ionutleca ionutleca requested a review from JamesBurnside June 3, 2021 08:13
Copy link
Member

@JamesBurnside JamesBurnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and using this solution in a fork of this repo for triggering an ADO release pipeline with variables that needed set. Approving but one more small change needed where the js file needs rebuilt to include the latest change 👍

@ionutleca ionutleca force-pushed the feature/add-pipeline-variables branch from e6014dc to a4321d6 Compare June 3, 2021 15:43
@thesattiraju thesattiraju merged commit 3cc9db1 into Azure:master Jun 7, 2021
thesattiraju pushed a commit that referenced this pull request Jun 7, 2021
* Add pipeline variables

* Better variables handling
Josh-01 added a commit that referenced this pull request Jan 28, 2022
* Feature/add pipeline variables (#11)

* Add pipeline variables

* Better variables handling

* Update README.md

* Update README.md

Co-authored-by: ionutleca <ionut.leca.93@gmail.com>
Co-authored-by: Jyotsna <Josh-01@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants