Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Henry/retrieval #50

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Henry/retrieval #50

wants to merge 6 commits into from

Conversation

jazmiahenry
Copy link
Contributor

Description

  • Documentation for Bonsai data retrieval.

Type of change

Added doc for Bonsai data retrieval and photos for the doc.

How Has This Been Tested?

Testing not necessary

Checklist:

  • I have squashed my previous commits into one commit and added a meaningful commit message.
  • My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

juanvergaramunoz and others added 3 commits August 31, 2023 23:40
@juanvergaramunoz
update download instructions
cbf76f6 
- clarify default option for inkling should be Bonsai Reports.
- clarify unmanaged sims are unneeded unless you are training brains.
- clarify they can download the docker file that contains their sim.
-- we are not providing instructions to unpack the simulation.
- add a "Reward Trainnig Graph" section.
-- recommend downloading a screenshot of the REWARDS graph.
- add retrival of CA episodic logs from Log Analytics.
- add a note to recommend taking a screenshot of complex concept graphs.
- clarify the different files inside the Bonsai Report.
@jostrow
Lots of small edits
86e860d
@juanvergaramunoz
beautify plot
e17c833 
- add image to readme to clarify how to get to the rewards plot.
- fix reference to exported docker image.
-- previously, it read 'docker file'.
juanvergaramunoz
juanvergaramunoz approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@juanvergaramunoz juanvergaramunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document reviewed by @juanvergaramunoz & @jostrow. Ready to be merged

@juanvergaramunoz
rn filename
4ac5773 
- from 'removing' to 'downloading'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvergaramunoz juanvergaramunoz juanvergaramunoz approved these changes

@mzat-msft mzat-msft Awaiting requested review from mzat-msft mzat-msft is a code owner

@akzaidi akzaidi Awaiting requested review from akzaidi akzaidi is a code owner

@ucabmir ucabmir Awaiting requested review from ucabmir ucabmir is a code owner

@sadekbaroudi sadekbaroudi Awaiting requested review from sadekbaroudi sadekbaroudi is a code owner

@jillianmclements jillianmclements Awaiting requested review from jillianmclements jillianmclements is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jazmiahenry @juanvergaramunoz @jostrow