Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enable SAPHanaSR-angi configuration for scale-up configurations #664

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

hdamecharla
Copy link
Member

This pull request includes several updates and improvements to configuration files and playbooks in the Ansible deployment scripts. The changes focus on standardizing configurations, improving readability, and ensuring proper functionality for high availability setups.

Terraform updates:

  • Terraform changes for adding SAPHanaSR-angi resource agent in tfvars via the variable use_sles_saphanasr_angi. When declared, the variable will be persisted as use_hanasr_angi in the sap-parameters.yaml file. This variable allows users to configure the SAPHanaSR-angi hook for scale-up scenarios.

Ansible playbook updates:

  • deploy/ansible/roles-sap/5.5-hanadb-pacemaker/: Updated role to accept new variable use_hanasr_angi to configure SAPHanaSR-angi hook for scale-up scenarios.

  • deploy/ansible/playbook_04_00_01_db_ha.yaml: Added quotes around task names and adjusted conditions to ensure the proper execution of tasks related to database high availability.

  • deploy/ansible/roles-os/1.17-generic-pacemaker/tasks/1.17.2.0-cluster-Suse.yml: Reorganized tasks to ensure proper registration of results and added missing register and failed_when statements for better error handling.

Minor updates:

  • deploy/ansible/roles-os/1.3-repository/vars/repos.yaml: Added support for sles15.6 to the repository variables.

  • deploy/ansible/roles-os/1.4-packages/vars/os-packages.yaml: Adjusted comments for better readability and consistency.

Configuration improvements:

  • .editorconfig: Added configurations for line endings, character set, and trimming of trailing whitespace for various file types. This helps standardize coding styles across different file formats.

…e for SAPHanaSr-angi hook usage and output support
…figuration options. Some formatting and additional packages.
@hdamecharla hdamecharla added the enhancement New feature or request label Nov 23, 2024
@hdamecharla hdamecharla self-assigned this Nov 23, 2024
@hdamecharla hdamecharla requested a review from a team as a code owner November 23, 2024 14:32
@KimForss KimForss merged commit 2d5a38d into Azure:development Nov 24, 2024
2 checks passed
@hdamecharla hdamecharla deleted the hdamec/saphanasr-angi branch November 25, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants