Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved PowerShell code and removed unnecessary registry modification #28

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HotCakeX
Copy link

@HotCakeX HotCakeX commented Sep 2, 2024

What's New

  • Implemented lots of best practices such as using full cmdlet name in scripts instead of aliases.

  • Prevented unnecessary string interpolation for performance and security reasons.

  • Removed the unnecessary registry key modification related to preventing Standard user from changing network location in Firewall from public to private. Windows by default requires elevation for that change.

  • Used proper string validation for checking nulls, empty or whitespace.

  • Removed lots of unnecessary double or even triple new lines. The maximum empty lines between code is 1 now.

  • Fixed many typos in the comments and Readme documents.

  • Fixed Markdown readme formats by removing unnecessary empty lines that aren't even parsed by Markdown engine.

  • Merged 2 If statements because they were being used sequentially.

  • Used $null redirection instead of unnecessary variable assignment for JSON content tests.

  • Removed all of the unnecessary trailing whitespaces from the repo. They do not change any behavior of the code, text etc. whatsoever.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Removed all of the unnecessary trailing whitespaces from the repo. They do not change any behavior of the code, text etc. whatsoever.
Prevented unnecessary string interpolation, improves performance and security, and it follows the best practices.
Implemented lots of best practices such as using full cmdlet name in scripts instead of aliases.

Prevented unnecessary string interpolation for performance and security reasons.

Removed the unnecessary registry key modification related to preventing Standard user from changing network location in Firewall from public to private. Windows by default requires elevation for that change.

Used proper string validation for checking nulls, empty or whitespace.

Removed lots of unnecessary double or even triple new lines. The maximum empty lines between code is 1 now.

Fixed some typos in the comments.

Fixed Markdown readme formats by removing unnecessary empty lines that aren't even parsed by Markdown engine.

Merged 2 If statements because they were being used sequentially.

Used $null redirection instead of unnecessary variable assignment for JSON content tests.
Fixed many typos in the Readmes
@HotCakeX
Copy link
Author

HotCakeX commented Sep 2, 2024

If these changes are merged, I can begin fixing user issues too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant