Dynamically load SF apis without linking #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be able to do this using https://doc.rust-lang.org/nightly/std/sync/struct.LazyLock.html. |
rsajwani
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically load SF apis that previously requires linking. There are a very small number of APIs that are converted.
After this change, user can compile mssf and their apps without installing SF sdk.
This solves the windows import lib problems, and also get around of SF sdk installation problems on ubuntu20. U can also compile your app on linux distros that are not supported by SF, but this does not guarantee the app will be able to run.
Removes FabricTransport mod since no one is using it, and it is a burden to maintain.