New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to use install script #236

Merged

hemarina merged 53 commits into Azure:main from hemarina:fix-4631

Jan 21, 2025

Contributor

hemarina commented Jan 16, 2025 •

edited

Loading

use install script
npm run package
fix 4631

hemarina added 30 commits

January 7, 2025 21:06


          use install script

6c215df


          npm run package

e17c36e


          test

5a3775b


          test

2e52fe5


          remove sudo

bec661c


          fix auth bug

ca967e0


          add env

109afa6


          update "

ab87c94


          remove access to azdo

7ef2c41


          add path in windows

430da90


          add it to user level instead of machine level

5e4d8b4


          fix bug


          add \\

74222cd


          fix bug

2d4745d


          fix syntax

ea39cb6


          test env

286919e


          print env

5c10cd9


          fix bug

a6acdf5


          test

4c4b4c2


          use setx

2c5484f


          test

425c073


          test

b927615


          update to github path

c82dee4


          debug

a806210


          debug

8e7ca91


          debug

47b9557


          test

4be2597


          test

0d0a4c8


          test

b254940


          test

804fdda

hemarina and others added 3 commits

January 16, 2025 11:29


          Update src/main.ts

0b97387

Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>


          Update src/main.ts

a1e0f26

Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>


          npm run all with latest changes

JeffreyCA reviewed

View reviewed changes

src/main.ts Outdated Show resolved Hide resolved

JeffreyCA reviewed

View reviewed changes

src/main.ts Show resolved Hide resolved

JeffreyCA reviewed

View reviewed changes

src/main.ts Outdated Show resolved Hide resolved


          remove sudo from curl

6c207b1

vhvb1989 approved these changes

View reviewed changes

JeffreyCA reviewed

View reviewed changes

src/main.ts Outdated Show resolved Hide resolved

hemarina added 2 commits

January 16, 2025 15:02


          add return after core set failed and npm run all

9d75740


          remove second check on localAppDataPath

ec54600

JeffreyCA approved these changes

View reviewed changes

danieljurek reviewed

View reviewed changes

src/main.ts Outdated Show resolved Hide resolved

danieljurek reviewed

View reviewed changes

src/main.ts Outdated Show resolved Hide resolved

danieljurek reviewed

View reviewed changes

src/main.ts Outdated Show resolved Hide resolved

hemarina added 4 commits

January 17, 2025 16:03


          apply suggestion from review

79d9237


          npm run all and make sure localappdata check only in windows

e18145d


          test with -Verbose

bcfd37d


          use -Verbose:$true in windows

807331f

hemarina force-pushed the fix-4631 branch from 59c1545 to 807331f Compare

January 18, 2025 00:57

hemarina added 2 commits

January 17, 2025 17:51


          testing

731c8b8


          Print out verbose output

1f54981

danieljurek reviewed

View reviewed changes

Member

danieljurek left a comment

This is very close. Need some examples of failures in Linux, Windows, and macos

hemarina added 2 commits

January 21, 2025 11:01


          add azd version back

555ae18


          run azd version to verify installation in windows only

d224282

hemarina force-pushed the fix-4631 branch from 49b3bec to d224282 Compare

January 21, 2025 19:39

Contributor Author

hemarina commented Jan 21, 2025

Testing run for successfully installation with latest or other version and failures for unsupported version: https://github.com/hemarina/todo-python-mongo/actions/runs/12894579758

hemarina requested a review from danieljurek

January 21, 2025 20:26

danieljurek approved these changes

View reviewed changes

hemarina merged commit 1132d72 into Azure:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

danieljurek danieljurek approved these changes

JeffreyCA JeffreyCA approved these changes

vhvb1989 vhvb1989 approved these changes

ellismg Awaiting requested review from ellismg

wbreza Awaiting requested review from wbreza

weikanglim Awaiting requested review from weikanglim

Labels

None yet