Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure db config file for mgmt-framework and mgmt-common PR tests #170

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

sachinholla
Copy link
Contributor

Multi db enhancements in sonic-mgmt-common requires database_config.json
file for running tests. Updated mgmt-common and mgmt-framework PR test
runner scripts to setup the a dummy database_config.json file.
It includes only 1 local redis instance, running on standard port 6379.

@sachinholla
Copy link
Contributor Author

Hi @lguohan, can you please review and approve this? We are bringing in multi db config support into sonic-mgmt-common. PR unit tests will fail without these changes.
Thanks

Copy link
Member

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lguohan lguohan merged commit 6dbce1f into Azure:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants