-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick 17483 and 17378 from public master to msft/202205 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice data (#17378) These changes, in conjunction with NDK version >= 22.9.17 address the thermal logging issues discussed at Nokia-ION/ndk#27. While the changes contained at this PR do not require coupling to NDK version >= 22.9.17, thermal logging enhancements will not be available without updated NDK >= 22.9.17. Thus, coupling with NDK >=22.9.17 is preferred and recommended. Why I did it To address thermal logging deficiencies. Work item tracking Microsoft ADO (number only): 26365734 How I did it The following changes are included: Threshold configuration values are provided in the associated device data .json files. There is also a change included to better handle the condition where an SFP module read fails. Modify the module.py reboot to support reboot linecard from Supervisor - Modify reboot to call _reboot_imm for single IMM card reboot - Add log to the ndk_cmd to log the operation of "reboot-linecard" and "shutdown/satrtup the sfm" Add new nokia_cmd set command and modify show ndk-status output - Add a new function reboot_imm() to nokia_common.py to support reboot a single IMM slot from CPM - Added new command: nokia_cmd set reboot-linecard <slot> [forece] for CPM - Append a new column "RebootStatus" at the end of output of "nokia_cmd show ndk-status" - Provide ability for IMM to disable all transceiver module TX at reboot time - Remove defunct xcvr-resync service
…API reboot and Disable all SFPs (#17483) Why I did it When Supervisor card is rebooted by using PMON API, it takes about 90 seconds to trigger the shutdown in down path. At this time linecards have been up. This delays linecards database initialization which is trying to PING/PONG the database-chassis. To address this issue, we modified the NDK to use the system call with "sudo reboot" when the request is from PMON API on Supervisor case. The NDK version is 22.9.20 and greater. This new NDK requires this modifcaiton of platform_reboot to work with. Work item tracking Microsoft ADO (number only): 26365734 How I did it Modify the platform_reboot In Supervisor not to reboot all IMMs since it has been done in the function reboot() in module.py. Also handle the reboot-cause.txt for on the Supervisor when the reboot is request from PMON API. Modify the Nokia platform specific platform_reboot in linecard to disable all SPFs. This PR works with NDK version 22.9.20 and above Signed-off-by: mlok <marty.lok@nokia.com>
judyjoseph
approved these changes
Jan 8, 2024
anamehra
pushed a commit
to anamehra/sonic-buildimage-msft
that referenced
this pull request
Jan 23, 2024
…y (#16152) #### Why I did it src/linkmgrd ``` * 40113fd - (HEAD -> 202305, origin/202305) [active-standby] Fix extra toggle observed in `config reload` (Azure#216) (2 days ago) [Longxiang Lyu] * b6d40fc - Add ADO to the PR template (Azure#215) (2 days ago) [Longxiang Lyu] * fe41ad2 - [active-standby] Write `unhealthy` is default route `N/A` (Azure#214) (2 days ago) [Longxiang Lyu] * 8ff265c - [link prober] Increase pause/restart probe log verbosity (Azure#213) (2 days ago) [Longxiang Lyu] ``` #### How I did it #### How to verify it #### Description for the changelog
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage-msft
that referenced
this pull request
Apr 9, 2024
…y (#16105) src/linkmgrd * 6ce71ba - (HEAD -> 202205, origin/202205) Add ADO to the PR template (Azure#215) (4 hours ago) [Longxiang Lyu] * 1010d93 - [active-standby] Write `unhealthy` is default route `N/A` (Azure#214) (4 hours ago) [Longxiang Lyu] * 15e9ca2 - [link prober] Increase pause/restart probe log verbosity (Azure#213) (4 hours ago) [Longxiang Lyu]
jon-nokia
pushed a commit
to jon-nokia/sonic-buildimage-msft
that referenced
this pull request
May 3, 2024
…y (#15952) #### Why I did it src/linkmgrd ``` * aa902a3 - (HEAD -> master, origin/master, origin/HEAD) [link prober] Increase pause/restart probe log verbosity (Azure#213) (3 days ago) [Longxiang Lyu] * 736cdda - [active-standby] Write `unhealthy` is default route `N/A` (Azure#214) (3 days ago) [Longxiang Lyu] * e923e15 - Add ADO to the PR template (Azure#215) (4 days ago) [Longxiang Lyu] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to manually cherry-pick these two PRs from public master to msft repo 202205 branch that are needed for the Nokia NDK 22.9.21
sonic-net/sonic-buildimage#17483
sonic-net/sonic-buildimage#17378
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)