Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dhcpv6 option yang model #16290

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kellyyeh
Copy link
Contributor

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lguohan lguohan added the YANG YANG model related changes label Sep 23, 2023
kellyyeh and others added 5 commits February 28, 2024 19:53
Add support container in list

Signed-off-by: vkuk <vkuk@marvell.com>
Add support container in list

Signed-off-by: vkuk <vkuk@marvell.com>
Added test yang model for single/multiple choice(s) in container/list
Add test yang model for container in list

Signed-off-by: vkuk <vkuk@marvell.com>
qiluo-msft pushed a commit that referenced this pull request Mar 21, 2024
Fixes "Missing container in list support in YANG Model #16704"

Why I did it
Adds support for container in list

How I did it
Identify container in list's leaf and add its data.

Fixes "Update dhcpv6 option yang model" #16290

Why I did it
Adds support for single "choice" statement in container/list

How I did it
Check if choice data is dictionary (instead of list).

How to verify it
Reconstruction details in bug's description.

Tested branch (Please provide the tested image version)
 202311
Description for the changelog
Adds support for container in list to yang parsing

Link to config_db schema for YANG module changes
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#dhcp_relay

Signed-off-by: vkuk [vkuk@marvell.com]
@vivekrnv
Copy link
Contributor

@kellyyeh, the PR to add container in list is merged. I guess you could re-open this PR

@kellyyeh kellyyeh marked this pull request as ready for review March 26, 2024 23:39
@kellyyeh kellyyeh requested a review from yaqiangz March 26, 2024 23:39
@yaqiangz
Copy link
Contributor

/azpw run Azure.sonic-buildimage

@yaqiangz yaqiangz closed this Nov 19, 2024
@yaqiangz yaqiangz reopened this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
YANG YANG model related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants