-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dhcpv6 option yang model #16290
Open
kellyyeh
wants to merge
10
commits into
sonic-net:master
Choose a base branch
from
kellyyeh:dhcp6-option-yang
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyyeh
force-pushed
the
dhcp6-option-yang
branch
from
August 30, 2023 00:19
9e20186
to
c38cc32
Compare
Add support container in list Signed-off-by: vkuk <vkuk@marvell.com>
Add support container in list Signed-off-by: vkuk <vkuk@marvell.com>
Added test yang model for single/multiple choice(s) in container/list Add test yang model for container in list Signed-off-by: vkuk <vkuk@marvell.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 21, 2024
Fixes "Missing container in list support in YANG Model #16704" Why I did it Adds support for container in list How I did it Identify container in list's leaf and add its data. Fixes "Update dhcpv6 option yang model" #16290 Why I did it Adds support for single "choice" statement in container/list How I did it Check if choice data is dictionary (instead of list). How to verify it Reconstruction details in bug's description. Tested branch (Please provide the tested image version) 202311 Description for the changelog Adds support for container in list to yang parsing Link to config_db schema for YANG module changes https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#dhcp_relay Signed-off-by: vkuk [vkuk@marvell.com]
@kellyyeh, the PR to add container in list is merged. I guess you could re-open this PR |
/azpw run Azure.sonic-buildimage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)