-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing container in list support in YANG Model #16704
Labels
Comments
To be taken up in Yang working group |
Hi @qiluo-msft , |
VladimirKuk
added a commit
to Marvell-sonic/sonic-buildimage
that referenced
this issue
Feb 13, 2024
Add support container in list Signed-off-by: vkuk <vkuk@marvell.com>
1 task
VladimirKuk
added a commit
to Marvell-sonic/sonic-buildimage-yang-bug
that referenced
this issue
Feb 13, 2024
Add support container in list Signed-off-by: vkuk <vkuk@marvell.com>
VladimirKuk
added a commit
to Marvell-sonic/sonic-buildimage-yang-bug
that referenced
this issue
Feb 25, 2024
Add support container in list Signed-off-by: vkuk <vkuk@marvell.com>
VladimirKuk
added a commit
to Marvell-sonic/sonic-buildimage
that referenced
this issue
Feb 25, 2024
Add support container in list Add support for single choice statement in container/list Signed-off-by: vkuk <vkuhk@marvell.com>
VladimirKuk
added a commit
to Marvell-sonic/sonic-buildimage-yang-bug
that referenced
this issue
Feb 26, 2024
Added test yang model for single/multiple choice(s) in container/list Add test yang model for container in list Signed-off-by: vkuk <vkuk@marvell.com>
kellyyeh
pushed a commit
to kellyyeh/sonic-buildimage
that referenced
this issue
Feb 29, 2024
Add support container in list Signed-off-by: vkuk <vkuk@marvell.com>
kellyyeh
pushed a commit
to kellyyeh/sonic-buildimage
that referenced
this issue
Feb 29, 2024
Add support container in list Signed-off-by: vkuk <vkuk@marvell.com>
kellyyeh
pushed a commit
to kellyyeh/sonic-buildimage
that referenced
this issue
Feb 29, 2024
Added test yang model for single/multiple choice(s) in container/list Add test yang model for container in list Signed-off-by: vkuk <vkuk@marvell.com>
qiluo-msft
pushed a commit
that referenced
this issue
Mar 21, 2024
Fixes "Missing container in list support in YANG Model #16704" Why I did it Adds support for container in list How I did it Identify container in list's leaf and add its data. Fixes "Update dhcpv6 option yang model" #16290 Why I did it Adds support for single "choice" statement in container/list How I did it Check if choice data is dictionary (instead of list). How to verify it Reconstruction details in bug's description. Tested branch (Please provide the tested image version) 202311 Description for the changelog Adds support for container in list to yang parsing Link to config_db schema for YANG module changes https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#dhcp_relay Signed-off-by: vkuk [vkuk@marvell.com]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Currently having container in list for YANG Model fails PR check due to missing support of parsing container in list.
According to RFC, container inside a list is supported.
https://datatracker.ietf.org/doc/html/rfc7950#section-4.2.2.4
Config_db.json:
Corresponding Yang Model:
Steps to reproduce the issue:
Describe the results you received:
PR runs into build failure due to sonic yang xlate translation not supporting container inside a list.
sonic-buildimage/src/sonic-yang-mgmt/sonic_yang_ext.py at e286869b24992a6ee17a31a76bbd54bf186fc383 · sonic-net/sonic-buildimage (github.com)
Error encountered:
Describe the results you expected:
PR check passing
Output of
show version
:Output of
show techsupport
:Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: