IGMP Snooping Mclag Support #4489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tylerlinp , will you review this one? |
|
@ashok-krishnegowda , there are lots of conflicts, can you address the conflicts? |
jianjundong
reviewed
Jun 3, 2020
|
In mlacp_fsm_update_l2mc_entry_from_peer(), if receives one LEAVE message from peer, it seems that the corresponding item may be remove from msg_list immediately and then free. In this case, the corresponding item in msg_list is not needed to sync to peer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To add IGMP Snooping feature support across MLAG as described in HLD.
MCLAG HLD
https://github.com/Azure/SONiC/blob/f478fe7cbc03c144f3b147e9638f460f764ce4b7/doc/Sonic-mclag-hld.md
IGMP Snooping HLD
sonic-net/SONiC#426
- How I did it
Accomplished it according MCLAG HLD and IGMP Snooping HLD document.
- How to verify it
Built and verified on local setup.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)