Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L2MCD:IGMP Snooping Implementation First Commit #1211

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

L2MCD:IGMP Snooping Implementation First Commit #1211

wants to merge 4 commits into from

Conversation

benzeerbava
Copy link

What I did

Why I did it

How I verified it

Details if related

Battier
Battier reviewed Mar 15, 2021
View reviewed changes
orchagent/Makefile.am
@@ -56,7 +56,9 @@ orchagent_SOURCES = \
sfloworch.cpp \
chassisorch.cpp \
debugcounterorch.cpp \
natorch.cpp
natorch.cpp \
l2mcorch.cpp \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ben,
I didn't find both l2mcorch.cpp and l2mcorch.h in this PR, seems like you forgot to add them.
Could you please kindly take a look? Thanks in advance.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Due to the requirement to upload as small patches, the changes are uploaded through my other user profile
benzeerbava

https://github.com/benzeerbava/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your timely response, Ben.
I have checked your profiles, but still didn't find them ( l2mcorch.cpp and l2mcorch.h ).
Could you please kindly share the PR link with me?

@benzeerbava
Copy link
Author

benzeerbava commented Mar 15, 2021 via email

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@jleveque
[show/fgnhg.py] Fix whitespace issues (sonic-net#1211)
061f428 
- Replace tabs with spaces
- Fix alignment
- Remove trailing whitespace
- Remove spaces where not necessary, add spaces where necessary
- Reorganize imports per PEP8 standards
@prsunny prsunny self-requested a review as a code owner September 2, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benzeerb benzeerb benzeerb left review comments

@Battier Battier Battier left review comments

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benzeerbava @Battier @benzeerb