[Mellanox] Implement new platform API for SONiC physical entity mib extension #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
This pull request introduces 10 alerts when merging 30bad8c into 5708e32 - view on LGTM.com new alerts:
|
|
The LGTM check shows "10 for Wrong number of arguments in a class instantiation", actually it is missreport. It checks non-mellanox API with mellanox code change. |
3 tasks
3 tasks
|
Please fix conflicts |
|
This pull request introduces 2 alerts when merging 7b27c7c into 5486f87 - view on LGTM.com new alerts:
|
|
The LGTM warning is not a real issue. |
|
retest broadcom please |
keboliu
approved these changes
Nov 11, 2020
|
@jleveque would you please help to check? this PR is to support the new physical Entity MIB. |
jleveque
approved these changes
Nov 17, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…xtension (sonic-net#5645) In order to support SONiC physical entity mib extension, a few new platform API are added to sonic-platform-common, this PR is to provide an mellanox platform implementation for those new APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
In order to support SONiC physical entity mib extension, a few new platform API are added to sonic-platform-common, this PR is to provide an mellanox platform implementation for those new APIs.
- How I did it
Implement all new APIs.
- How to verify it
Manual tests on MSN2410.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)