[Mellanox] Implement new platform API for SONiC physical entity mib extension #23

Junchao-Mellanox · 2020-08-31T08:38:49Z

- Why I did it

In order to support SONiC physical entity mib extension, a few new platform API are added to sonic-platform-common, this PR is to provide an mellanox platform implementation for those new APIs.

- How I did it

Implement all new APIs.

- How to verify it

Manual tests on MSN2410.

- Which release branch to backport (provide reason below if selected)

201811
201911
202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

keboliu · 2020-09-04T07:10:09Z

platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py

+        Returns:
+            integer: The 1-based relative physical position in parent device
+        """
+        return -1


"-1" as a special indicator shall be documented in the description of the API definition.

keboliu · 2020-09-04T07:15:24Z

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

@@ -294,6 +295,10 @@ def __init__(self, sfp_index, sfp_type):
        self.sdk_handle = None
        self.sdk_index = sfp_index

+        # initialize SFP thermal list
+        from .thermal import initialize_sfp_thermals
+        initialize_sfp_thermals(platform, self._thermal_list, self.index)


do we need this? Is it possible to keep using the thermal value in the current TRANSCEIVER_DOM_INFO table?

Yes, we need this. TRANSCEIVER_DOM_SENSOR table does not contains all the information that TEMPERATURE_INFO table needs. For example, warning status, critical_high_threshold and critical_low_threshold.

keboliu · 2020-09-04T07:16:35Z

platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py

@@ -2149,3 +2154,19 @@ def set_power_override(self, power_override, power_set):
            return self._write_i2c_via_mcia(0, 0x50, MCIA_ADDR_POWER_OVERRIDE, power_set_bit|power_override_bit, power_override_mask)
        else:
            return NotImplementedError
+
+    def get_position_in_parent(self):


interface index is enough? do we need this?

Junchao-Mellanox · 2020-10-16T08:00:46Z

sonic-net#5645

This update brings in the following commits. 86c1108 Enable arm architecture to build in addition to amd64 (#37) 4acb2c3 fix bugs and enhance Transformer (#35) 49e5a22 ygot related enhancements and fixes (#34) 51224de Fix ietf yang search path for cvl schema builds (#32) 3c6cdb3 CVL Changes #8: 'must' and 'when' expression evaluation (#31) dabf231 CVL Changes #7: 'leafref' evaluation (#28) 6f9535f CVL Changes #6: Customized Xpath Engine integration (#27) 5e2466b DB-Layer fixes/enhancements (#26) 9a27302 CVL Changes #4: Implementation of new CVL APIs (#22) dbf1093 Translib support for authorization, yang versioning and Delete flag (#21) 80f369e CVL Changes #5: YParser enhancement (#23) 904ce18 CVL Changes #3: Multi-db instance support (#20) 9d24a34 CVL Changes #2: YValidator infra changes for evaluating xpath expression (#19) f3fc40f CVL Changes #1: Initial CVL code reorganization and common infra changes (#18) 4922601 Bulk and RPC API support in translib (#16) 1d730df RFC7895 yang module library implementation (#15)

Advance submodule update with the following changes: 4475750 Config reload fix (#29) cf60d5e [ci]: add proper azp (#26) f0fbfe7 [CI] Set up CI with Azure Pipelines (#25) 879d7bd Include port default fec configuration to be included in ZTP configuration (#24) a6ae955 Add a pre-defined plugin to download a list of files (#23) 6f0305b [MultiDB] Add multidb support to sonic-ztp (#16)

* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> * Added BFN PSU cache (#9) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Fans and Fantray platform APIs update (#7) * [BFN] Updated SFP platform APIs (#10) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [BFN] Updated platform API for thermal (#8) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "[BFN] Fans and Fantray platform APIs update (#7)" (#11) This reverts commit c62a733. * Add support health monitor system (#15) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (#14) * Fix fix_alignment (#17) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * [BFN] Improvement show environment (#16) * Added PSU temperature skip into platform.json (#18) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] fix fan status from Not OK to Ok (#19) * [BFN] Updated SFP platform plugin (#13) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21) Signed-off-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com> * [barefoot] Tmp fix vendor_rev (#22) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [Newport] Thermal manager (#23) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (#30) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> Co-authored-by: KostiantynYarovyiBf <kostiantynx.yarovyi@intel.com> Co-authored-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> Co-authored-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> Co-authored-by: Volodymyr Boiko <volodymyrx.boiko@intel.com> Co-authored-by: Petro Bratash <petrox.bratash@intel.com> Co-authored-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

ce72b0d Longxiang Lyu Thu Feb 24 06:05:12 2022 Put handler member functions as virtual in base (#30) ef59e4f Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) 2d12892 Longxiang Lyu Wed Feb 16 03:32:06 2022 Rename LinkManagerStateMachine to ActiveStandbyStateMachine (#26) f38634c Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) a8434dd Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 2ebdb2b Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24)

Changes: Update submodule branch to 202012 [sonic-linkmgrd][202012] submodule update a8ddff5 Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) a3f78a3 Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) 05156fb Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 74529ef Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24) sign-off: Jing Zhang zhangjing@microsoft.com

[sonic-linkmgrd][master] Submodule Update 9c8a16e Jing Zhang Sun Jun 5 08:27:07 2022 -0700 Separate I2C mux state probing and gRPC forwarding state probing (#86) 491c4ee Longxiang Lyu Sun Jun 5 23:26:19 2022 +0800 Fix peer mux wait back off factor (#84) a0b6b14 Jing Zhang Wed Jun 1 10:33:12 2022 -0700 Revert "Update log level for mux probing and mux state chance (#23)" (#85) 3c2b546 Jing Zhang Tue May 31 10:14:42 2022 -0700 Add default route support to active-active state machine (#78) 6fa892e Longxiang Lyu Fri May 27 09:15:06 2022 +0800 Degrade LinkProberStateMachineBase virtual function logging level (#80) 7b695ca Longxiang Lyu Fri May 27 09:14:02 2022 +0800 Fix mux wait timer and peer mux wait timer (#81)

linkmgrd: * d27ca81 2022-06-05 | Separate I2C mux state probing and gRPC forwarding state probing (#86) (HEAD -> 202205) [Jing Zhang] * 9d7d301 2022-06-01 | Revert "Update log level for mux probing and mux state chance (#23)" (#85) [Jing Zhang] * 60d3d77 2022-06-05 | Fix peer mux wait back off factor (#84) [Longxiang Lyu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

[sonic-linkmgrd][202012] submodule update 0839af2 Longxiang Lyu Wed Jun 15 08:46:21 2022 +0800 [202012] Fix IP header checksum in handleSendSwitchCommand (#89) afc4972 Jing Zhang Wed Jun 1 10:33:12 2022 -0700 Revert "Update log level for mux probing and mux state chance (#23)" (#85) ed52d0a Longxiang Lyu Tue May 31 10:28:30 2022 +0800 Add a command line option to store logs into a separate file (#83) sign-off: Jing Zhang zhangjing@microsoft.com

…tically (sonic-net#19465) src/sonic-dash-api * 43d9f7c - (HEAD -> 202311, origin/202311) [build]Update pool sonicbld to sonic-ububtu-1c since it's deprecated (#23) (23 hours ago) [Jianquan Ye]

Junchao-Mellanox added 5 commits August 25, 2020 18:00

Mellanox platform API change for SONiC Physical MIB Entity feature

838efec

Merge branch 'master' into phy-mibs

2497361

Fix unit test issue

4cd10f9

Fix issue found in manual test

25f48ab

Fix thermal order

4a2f614

keboliu reviewed Sep 4, 2020

View reviewed changes

Junchao-Mellanox and others added 3 commits September 9, 2020 10:34

Fix review comment

c135445

Fix issue: PSU fan should not be there if PSU is absence

938ed53

Merge branch 'master' into phy-mibs

2e3ef5b

keboliu approved these changes Oct 16, 2020

View reviewed changes

Fix LGTM warnings

30bad8c

Junchao-Mellanox closed this Oct 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox] Implement new platform API for SONiC physical entity mib extension #23

[Mellanox] Implement new platform API for SONiC physical entity mib extension #23

Junchao-Mellanox commented Aug 31, 2020

keboliu Sep 4, 2020

Junchao-Mellanox Oct 15, 2020

keboliu Sep 4, 2020

Junchao-Mellanox Sep 8, 2020

keboliu Sep 4, 2020

Junchao-Mellanox Oct 15, 2020

Junchao-Mellanox commented Oct 16, 2020

[Mellanox] Implement new platform API for SONiC physical entity mib extension #23

[Mellanox] Implement new platform API for SONiC physical entity mib extension #23

Conversation

Junchao-Mellanox commented Aug 31, 2020

keboliu Sep 4, 2020

Choose a reason for hiding this comment

Junchao-Mellanox Oct 15, 2020

Choose a reason for hiding this comment

keboliu Sep 4, 2020

Choose a reason for hiding this comment

Junchao-Mellanox Sep 8, 2020

Choose a reason for hiding this comment

keboliu Sep 4, 2020

Choose a reason for hiding this comment

Junchao-Mellanox Oct 15, 2020

Choose a reason for hiding this comment

Junchao-Mellanox commented Oct 16, 2020