[YANG] Enhance the port yang model with new port fields: adv_speeds, interface_type and adv_interface_types #6948
Conversation
|
Hi @lguohan, @praveen-li, could you please review again? Thanks. |
|
@Junchao-Mellanox, there are unanswered question, can you address them? |
|
Hi @lguohan, @praveen-li, could you please review again? Thanks. |
|
Hi @lguohan ， could you please kindly review again? |
|
use the keyword description, please refer to the yang model. |
|
can you resolve the conflict? any update on the comments? |
Conflicts: src/sonic-yang-models/tests/yang_model_tests/test_yang_model.py src/sonic-yang-models/tests/yang_model_tests/yangTest.json
…x/sonic-buildimage into port-auto-neg-yang-model Conflicts: src/sonic-yang-models/yang-models/sonic-port.yang
|
Hi @lguohan, I fixed all comment, could you please help review again? Thanks, |
|
@praveen-li can you please approve? if it is we can go a head and merge. |
|
need to change the title to reflect the pr |
liat-grozovik
changed the title
liat-grozovik
changed the title
done. please recheck |
|
@praveen-li and @lguohan any further comments? |
|
|
||
| type union { | ||
| type uint32 { | ||
| range 1..400000; |
There was a problem hiding this comment.
So there is no other constraint on adv speed?, it can take any number of values. Kindly point to the correct paragraph in HLD for this plz, I will have a look. Thx
There was a problem hiding this comment.
Yes, there is no other constraint for adv_speeds, I am following the field "speed" in the same yang model file. HLD: https://github.com/Junchao-Mellanox/SONiC/blob/port-auto-neg/doc/port_auto_neg/port-auto-negotiation-design.md#config-advertised-speeds
| } | ||
|
|
||
| leaf-list adv_interface_types { | ||
| description "Port advertised interface type, valid value could be a list of stypes:interface_type or all"; |
There was a problem hiding this comment.
Kindly point to the correct paragraph in HLD here in comment, thanks again
There was a problem hiding this comment.
There was a problem hiding this comment.
I cannot add the HLD paragraph to the comment here because HLD is not approved yet. And HLD approval requires YANG model PR approval.
|
Hi @praveen-li, could you please review again? |
|
Hi @prsunny - could you please take a look, thanks. |
|
@prsunny @praveen-li would you please have a look? |
|
@praveen-li , lgtm, can you also check? |
|
@praveen-li - could you please review as well. |
|
@praveen-li would you please check? |
|
Hi @praveen-li - Can you please review and approve at the earliest. |
…interface_type and adv_interface_types (sonic-net#6948) Enhance the port yang model with new port fields: adv_speeds, interface_types and adv_interface_types Refer to HLD sonic-net/SONiC#732
- Why I did it
Enhance the port yang model with new port fields: adv_speeds, interface_types and adv_interface_types
Refer to HLD sonic-net/SONiC#732
- How I did it
Add fields adv_speeds, interface_type, adv_interface_types
- How to verify it
Add yang unit test and verify build is not broken.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)