[master] Fix exception in update_data of rfc4363.py #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tim-rj <sonic_rd@ruijie.com.cn>
tim-rj
changed the title
|
help forward this, thanks! |
qiluo-msft
reviewed
Sep 17, 2021
| @@ -70,6 +70,8 @@ def update_data(self): | |||
| if bridge_port_id not in self.if_bpid_map: | |||
| continue | |||
| port_id = self.if_bpid_map[bridge_port_id] | |||
| if port_id not in self.if_id_map: | |||
There was a problem hiding this comment.
Could you give more description about your topology and config? I guess your DUT has a PortChannel in Vlan, and there are traffic hit the port in PortChannel. If this is true, we recently fixed it by #203. Could you try latest master code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tim-rj sonic_rd@ruijie.com.cn
- What I did
Fix sonic-net/sonic-buildimage#5345
- How I did it
If port_id does not exist in if_id_map, do not use it.
- How to verify it
Up and down portchannel
Check is there exception log of rfc4363.py in /var/log/syslog
- Log before commit
- Log after commit
No exception log
- Description for the changelog
Avoid exception when handling update_data in rfc4363.py in case of invalid db entry.