Implement rfc4363 FdbUpdater for lag inside vlan #203
Conversation
qiluo-msft
force-pushed
the
qiluo/laginvlan
branch
from
477f6db to
6afaaa3
Compare
| db_conn.connect(COUNTERS_DB) | ||
| lag_sai_map = db_conn.get_all(COUNTERS_DB, "COUNTERS_LAG_NAME_MAP") | ||
| for name, sai_id in lag_sai_map.items(): | ||
| sai_id_key = get_sai_id_key(db_conn.namespace, sai_id.lstrip("oid:0x")) |
There was a problem hiding this comment.
Can we use if_lag_name_map from port_util.if_lag_name_map() ? #Resolved
There was a problem hiding this comment.
The function get_interface_oid_map returns both port and lag. So not fit well.
In reply to: 594597081 [](ancestors = 594597081)
| @@ -31,7 +32,7 @@ def fdb_vlanmac(self, fdb): | |||
| self.bvid_vlan_map[fdb["bvid"]] = vlan_id | |||
| else: | |||
| return None | |||
| if not isinstance(vlan_id, str): | |||
| if not isinstance(vlan_id, bytes) and not isinstance(vlan_id, str): | |||
There was a problem hiding this comment.
why is this change required? #Resolved
There was a problem hiding this comment.
I fixed it in above line, and this is not required anymore.
In reply to: 594597739 [](ancestors = 594597739)
| @@ -56,6 +61,20 @@ def test_getnextpdu(self): | |||
| self.assertEqual(value0.type_, ValueType.INTEGER) | |||
| self.assertEqual(value0.data, 113) | |||
|
|
|||
| def test_getnextpdu_lag(self): | |||
There was a problem hiding this comment.
can we add same case for multi-asic also . tests/namespace/test_fdb.py
There was a problem hiding this comment.
we currently skip the tests/namespace/test_fdb.py as fdb MIB is not modified to support for mulit-asic as it is a T0 topology feature.
There was a problem hiding this comment.
ok ideally we should remove test itself then.
- What I did Same as #203 But target on 201911 branch.
- What I did
Currently if there are lags in vlan, and FDB entries with lag will not visible in FdbUpdater.
- How I did it
Implement rfc4363 FdbUpdater for lag inside vlan
- How to verify it
Test in DUT, and add unit test.