[portmgrd/portsyncd] Refactor code so that portsyncd does not deal with configurations at run time #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenggen-xu
force-pushed
the
port-refactor-up
branch
2 times, most recently
from
8c9eac6
to
cd58f8c
Compare
…run time portmgrd will deal with configurations for both linux side and appDB. Added vs test cases for port config changes Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
zhenggen-xu
force-pushed
the
port-refactor-up
branch
from
cd58f8c
to
a993f7f
Compare
zhenggen-xu
changed the title
|
Please resolve the conflict first |
|
@zhenggen-xu , is this an enhancement or you encountered any issue with current model? |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Neetha John <nejo@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* [asan] suppress the static variable leaks This is to suppress ASAN false positives for static variables. For example, the ServiceMethodTable::m_slots is sometimes reported as leaked. Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com> * [asan] add missing SWSS_LOG_ENTER() Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code so that portsyncd does not deal with configurations at run time
portmgrd will deal with configurations for both linux side and appDB.
Added vs test cases for port config changes
Signed-off-by: Zhenggen Xu zxu@linkedin.com
What I did
Refactor code so that portsyncd does not deal with configurations at run time
portmgrd will deal with configurations for both linux side and appDB.
Added vs test cases for port config changes
Why I did it
Only one daemon is handling port configurations from cfg_db to app-db/linux.
How I verified it
vs test cases
Details if related
-- Initial configurations is not moved yet.
-- port_config.ini dependencies is not removed yet.