Layer 2 Forwarding Enhancements #885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: fdbshow does not show the portchannel name Fix: 1.Added port channel port oid to name mapping in COUNTERS_PORT_NAME_MAP table so that a given portchannel port oid will give port channel name 2. made fix to add add portchannel port oid to name mapping when addLag is done from portsorch. similarly removed the mapping when removeLag is done
|
Please exclude the file .DS_Store |
prsunny
reviewed
May 14, 2019
stcheng
reviewed
May 16, 2019
stcheng
reviewed
May 16, 2019
This was referenced May 23, 2019
|
retest this please |
|
@anilkpandey any updates? |
|
With the change there were compile errors related to some snmp scripts. I am yet to fix those. Will send an update by next week. |
|
thanks! |
Layer 2 Forwarding Enhancements
anilkpandey
changed the title
|
Added code changes related to Layer 2 Forwarding Enhancements |
Layer 2 Forwarding Enhancements
Layer 2 Forwarding Enhancements
Updated to reflect latest code changes.
moved sai redis fdb event processing back to notification thread
Hi, I have added a new table LAG_NAME_MAP)TABLE in COUNTERS_DB. Here are the other pull requests related to this. Please check. sonic-net/sonic-swss-common#303 Also, please review new changes added to this pull request related to layer 2 Forwarding Enhancements. |
This was referenced Oct 8, 2019
Merged
|
This pull request introduces 46 alerts when merging bcaeb98 into 3829053 - view on LGTM.com new alerts:
|
|
@anilkpandey , this PR is pretty big and few other PRs are dependent on parts of your changes. Is it possible to split the PR based on functionality to make reviewing easy and merge those to unblock dependent PRs? |
|
Yes, I will split the changes and submit smaller review in a few days.
On Tue, May 5, 2020 at 4:02 PM Prince Sunny ***@***.***> wrote:
@anilkpandey <https://github.com/anilkpandey> , this PR is pretty big and
few other PRs are dependent on parts of your changes. Is it possible to
split the PR based on functionality to make reviewing easy and merge those
to unblock dependent PRs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#885 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLPOULF4EFO3JZGJEMCGQDRQCLGPANCNFSM4HMG5JQA>
.
--
Sent from my iPhone
|
jainp1979
added a commit
to jainp1979/sonic-swss
that referenced
this pull request
Jun 23, 2020
1. Review comments incorporated 2. Dependency for PR sonic-net#885 is resolved 3. Added test_evpn_fdb.py pytest script to verify EVPN-VXLAN-FDB 4. compiled and verified the FDB functionality with EVPN 5. Changes to handle the static mac and aging from CLI
jainp1979
added a commit
to jainp1979/sonic-swss
that referenced
this pull request
Jun 23, 2020
1. Review comments incorporated 2. Dependency for PR sonic-net#885 is resolved 3. Added test_evpn_fdb.py pytest script to verify EVPN-VXLAN-FDB 4. compiled and verified the FDB functionality with EVPN 5. Changes to handle the static mac and aging from CLI
jainp1979
added a commit
to jainp1979/sonic-swss
that referenced
this pull request
Sep 27, 2020
1. Review comments incorporated 2. Dependency for PR sonic-net#885 is resolved 3. Added test_evpn_fdb.py pytest script to verify EVPN-VXLAN-FDB 4. compiled and verified the FDB functionality with EVPN 5. Changes to handle the static mac and aging from CLI
|
This pull request introduces 1 alert when merging 56e330e into c0f951c - view on LGTM.com new alerts:
|
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…g DB (sonic-net#885) Fix is_mgmt_vrf_enabled for the case where MGMT_VRF_CONFIG is not at all in the config DB. This is the case where mgmt vrf is never configured. The function throws error at File "/usr/lib/python2.7/dist-packages/show/main.py", line 651, in is_mgmt_vrf_enabled mvrf_dict = json.loads(p.stdout.read()) Two show commands uses is_mgmt_vrf_enabled. "show mgmt-vrf" and "show ntp" Both commands throw error if mgmt vrf is never configured Co-authored-by: Bing Sun <Bing_Sun@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code changes related to Layer 2 Forwarding Enhancements:
Changes are as mentioned in the HLD.