-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[portsorch]: add support to set mac-address learning attribute on bridge-port #809
Conversation
pull from origin
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
learning mode can also be supported in lag, but it looks like the code here does not consider that scenario. |
Lag is also supported, please see the function PortsOrch::doLagTask(Consumer &consumer). Thinks. |
Learning mode has been supported in lag, but the corresponding vs-test requires lag-name-oid-map. PR#885 will provide support for lag-name-oid-map, so the vs-test code can only be provided after its modification is completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add vstest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also add unit tests. thanks!
Signed-off-by: leo.li <leo.li@nephosinc.com>
The vstest has been added, please review. Thanks! |
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
…/sonic-swss into bridge-port-mac-learn
@stcheng we has refined code according to your suggestion. Pls review thanks. |
Signed-off-by: leo.li <leo.li@nephosinc.com>
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shine4chen: thanks for addressing my review comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking care of review comments
retest this please |
32416e3
to
53a3f1e
Compare
53a3f1e
to
92100be
Compare
Introduce `gbsyncdmgrd`, which will be responsible for spawning and watching all gearbox syncd processes. `gbsyncdmgrd` is intended to supplant `gbsyncd_startup.py`. But until all references have been updated, we keep both, and I have added a deprecation warning to `gbsyncd_startup.py`.
What I did
add support to set mac-address learning attribute on bridge-port
Why I did it
Mclag feature need this. And it is common attribute for bridge-port.
How I verified it
compile and test on nephos lab
Details if related