[sonic-utilities] CLI support for port auto negotiation #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: tests/mock_tables/state_db.json
Conflicts: scripts/portconfig tests/mock_tables/state_db.json
|
This pull request introduces 1 alert when merging edc5f51 into e296a69 - view on LGTM.com new alerts:
|
|
The test case failures are not related to this change, could you please help re-trigger the test? |
|
The LGTM warning can be ignored. The warning code is for mock purpose. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request introduces 1 alert when merging 87d9861 into c166f66 - view on LGTM.com new alerts:
|
jleveque
suggested changes
Apr 28, 2021
The unused import is for mock purpose: import mock_tables.dbconnector |
Ah, yeah. That's annoying. We need to find a better way to do this (maybe using |
jleveque
previously approved these changes
Apr 30, 2021
|
This pull request introduces 1 alert when merging 8eaf2e8 into 615e531 - view on LGTM.com new alerts:
|
The unused import is for mock purpose |
jleveque
approved these changes
May 7, 2021
jleveque
suggested changes
May 7, 2021
…lities into port-auto-neg
|
This pull request introduces 1 alert when merging 4adca3e into a71ff02 - view on LGTM.com new alerts:
|
jleveque
approved these changes
May 7, 2021
liat-grozovik
pushed a commit
that referenced
this pull request
May 23, 2021
…rator test cases as well (#1614) - What I did Originally, the method advance_version_for_expected_database was introduced (in #1566) to handle the case the latest version in CONFIG_DB is greater than the latest version in mellanox_buffer_migrator. Now there are other database migrators whose test cases can also encounter this situation, like port auto-negotiation (#1568) and port-channel for LACP key (#1473). So I would like to make the method public, available for all database migrators. Related database migrator test cases have been updated accordingly. - How to verify it Run the unit test. Signed-off-by: Stephen Sun <stephens@nvidia.com>
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
#### What I did 1. Add CLI support for port auto negotiation feature. 2. Add db_migrator change for auto negotiation feature 2. Add unit test cases for all changes #### How I did it 1. Add new subcommands to "config interface" command group to allow user configuring port auto negotiation 2. Add new subcommands to "show interfaces" command group to allow user show auto negotiation status 3. In db_migrator.py, change auto negotiation related DB field to latest one
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
…rator test cases as well (sonic-net#1614) - What I did Originally, the method advance_version_for_expected_database was introduced (in sonic-net#1566) to handle the case the latest version in CONFIG_DB is greater than the latest version in mellanox_buffer_migrator. Now there are other database migrators whose test cases can also encounter this situation, like port auto-negotiation (sonic-net#1568) and port-channel for LACP key (sonic-net#1473). So I would like to make the method public, available for all database migrators. Related database migrator test cases have been updated accordingly. - How to verify it Run the unit test. Signed-off-by: Stephen Sun <stephens@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-utilities
that referenced
this pull request
Aug 10, 2021
…rator test cases as well (sonic-net#1614) - What I did Originally, the method advance_version_for_expected_database was introduced (in sonic-net#1566) to handle the case the latest version in CONFIG_DB is greater than the latest version in mellanox_buffer_migrator. Now there are other database migrators whose test cases can also encounter this situation, like port auto-negotiation (sonic-net#1568) and port-channel for LACP key (sonic-net#1473). So I would like to make the method public, available for all database migrators. Related database migrator test cases have been updated accordingly. - How to verify it Run the unit test. Signed-off-by: Stephen Sun <stephens@nvidia.com>
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Sep 13, 2021
1. Add CLI support for port auto negotiation feature. 2. Add db_migrator change for auto negotiation feature 2. Add unit test cases for all changes 1. Add new subcommands to "config interface" command group to allow user configuring port auto negotiation 2. Add new subcommands to "show interfaces" command group to allow user show auto negotiation status 3. In db_migrator.py, change auto negotiation related DB field to latest one
lguohan
pushed a commit
that referenced
this pull request
Sep 15, 2021
* [sonic-utilities] CLI support for port auto negotiation (#1568) 1. Add CLI support for port auto negotiation feature. 2. Add db_migrator change for auto negotiation feature 2. Add unit test cases for all changes 1. Add new subcommands to "config interface" command group to allow user configuring port auto negotiation 2. Add new subcommands to "show interfaces" command group to allow user show auto negotiation status 3. In db_migrator.py, change auto negotiation related DB field to latest one Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> Co-authored-by: Junchao-Mellanox <57339448+Junchao-Mellanox@users.noreply.github.com>
|
This PR could not be cleanly cherry-picked to 202012. Please submit another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Add unit tests for each new commands and db_migrator
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)