[202012][sonic-utilities] CLI support for port auto negotiation #1817

vdahiya12 · 2021-09-13T23:27:04Z

Add CLI support for port auto negotiation feature.
Add db_migrator change for auto negotiation feature
Add unit test cases for all changes
Add new subcommands to "config interface" command group to allow user configuring port auto negotiation
Add new subcommands to "show interfaces" command group to allow user show auto negotiation status
In db_migrator.py, change auto negotiation related DB field to latest one

Adding this PR because the cherry-pick from original PR #1568
has conflicts

What I did

How I did it

How to verify it

Ran the changes on Arista7050cx3 testbed

admin@sonic:~$ sudo config interface autoneg Ethernet96 enabled
admin@sonic:~$ echo $?
0

  Interface    Auto-Neg Mode    Speed    Oper    Admin
-----------  ---------------  -------  ------  -------
  Ethernet0              N/A     100G    down     down
  Ethernet4              N/A     100G    down       up
  Ethernet8              N/A     100G    down       up
 Ethernet12              N/A     100G    down       up
 Ethernet16              N/A     100G    down       up
 Ethernet20              N/A     100G    down     down
 Ethernet24         disabled     100G    down       up
 Ethernet28              N/A     100G    down       up
 Ethernet32              N/A     100G    down       up
 Ethernet36              N/A     100G    down       up
 Ethernet40              N/A     100G    down     down
 Ethernet44              N/A     100G    down       up
 Ethernet48              N/A     100G    down       up
 Ethernet52              N/A     100G    down       up
 Ethernet56              N/A     100G    down       up
 Ethernet60              N/A     100G    down       up
 Ethernet64              N/A     100G    down     down
 Ethernet68              N/A     100G    down     down
 Ethernet72              N/A     100G    down       up
 Ethernet76              N/A     100G    down       up
 Ethernet80              N/A     100G    down       up
 Ethernet84              N/A     100G    down     down
 Ethernet88              N/A     100G    down       up
 Ethernet92              N/A     100G    down       up
 Ethernet96          enabled     100G      up       up
Ethernet100              N/A     100G    down       up
Ethernet104              N/A     100G    down       up
Ethernet108              N/A     100G    down       up
Ethernet112              N/A     100G    down     down
Ethernet116              N/A     100G    down       up
Ethernet120              N/A     100G    down       up
Ethernet124              N/A     100G    down     down
Ethernet128              N/A      10G    down     down
Ethernet132              N/A      10G    down     down

admin@sonic:~$ sudo config interface autoneg Ethernet96 disabled
admin@sonic:~$ echo $?
0

admin@sonic:~$ show interfaces autoneg status
  Interface    Auto-Neg Mode    Speed    Oper    Admin
-----------  ---------------  -------  ------  -------
  Ethernet0              N/A     100G    down     down
  Ethernet4              N/A     100G    down       up
  Ethernet8              N/A     100G    down       up
 Ethernet12              N/A     100G    down       up
 Ethernet16              N/A     100G    down       up
 Ethernet20              N/A     100G    down     down
 Ethernet24          enabled     100G    down       up
 Ethernet28              N/A     100G    down       up
 Ethernet32              N/A     100G    down       up
 Ethernet36              N/A     100G    down       up
 Ethernet40              N/A     100G    down     down
 Ethernet44              N/A     100G    down       up
 Ethernet48              N/A     100G    down       up
 Ethernet52              N/A     100G    down       up
 Ethernet56              N/A     100G    down       up
 Ethernet60              N/A     100G    down       up
 Ethernet64              N/A     100G    down     down
 Ethernet68              N/A     100G    down     down
 Ethernet72              N/A     100G    down       up
 Ethernet76              N/A     100G    down       up
 Ethernet80              N/A     100G    down       up
 Ethernet84              N/A     100G    down     down
 Ethernet88              N/A     100G    down       up
 Ethernet92              N/A     100G    down       up
 Ethernet96         disabled     100G    down       up
Ethernet100              N/A     100G    down       up
Ethernet104              N/A     100G    down       up
Ethernet108              N/A     100G    down       up
Ethernet112              N/A     100G    down     down
Ethernet116              N/A     100G    down       up
Ethernet120              N/A     100G    down       up
Ethernet124              N/A     100G    down     down
Ethernet128              N/A      10G    down     down
Ethernet132              N/A      10G    down     down

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

1. Add CLI support for port auto negotiation feature. 2. Add db_migrator change for auto negotiation feature 2. Add unit test cases for all changes 1. Add new subcommands to "config interface" command group to allow user configuring port auto negotiation 2. Add new subcommands to "show interfaces" command group to allow user show auto negotiation status 3. In db_migrator.py, change auto negotiation related DB field to latest one

lgtm-com · 2021-09-13T23:35:18Z

This pull request introduces 2 alerts when merging 863f1c5 into d03ba4f - view on LGTM.com

new alerts:

2 for Unused import

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-09-14T06:05:54Z

This pull request introduces 2 alerts when merging 6297d51 into d03ba4f - view on LGTM.com

new alerts:

2 for Unused import

liat-grozovik · 2021-09-14T07:24:16Z

@prsunny @lguohan please don't merge yet.
As the feature is based on Nvidia contribution on 202106 we need to be sure the relevant SAI supports it before merging the capabilities and run all the available tests before that.
Also, can you please confirm the full feature is backported and not just the CLI? Can you please share list of backported PRs which required for this feature?

config/main.py

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-09-14T19:29:39Z

This pull request introduces 2 alerts when merging d425dd4 into d03ba4f - view on LGTM.com

new alerts:

2 for Unused import

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-09-14T19:50:52Z

This pull request introduces 2 alerts when merging 7cc0b39 into d03ba4f - view on LGTM.com

new alerts:

2 for Unused import

…ities into 202012

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-09-14T21:18:52Z

This pull request introduces 2 alerts when merging 6127d34 into d03ba4f - view on LGTM.com

new alerts:

2 for Unused import

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-09-14T23:17:33Z

This pull request introduces 2 alerts when merging 7ef0c31 into d03ba4f - view on LGTM.com

new alerts:

2 for Unused import

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-09-14T23:34:24Z

This pull request introduces 2 alerts when merging 65e2bb8 into d03ba4f - view on LGTM.com

new alerts:

2 for Unused import

lguohan · 2021-09-15T02:25:47Z

are we able to resolve the lgtm alert?

vdahiya12 · 2021-09-15T04:10:19Z

are we able to resolve the lgtm alert?

This LGTM, is for mock purposes and needs to be fix.
Because this is in portconfig, not in a test file. We need to eliminate this if os.environ["UTILITIES_UNIT_TESTING"] == "1": check from the source files, and move all of this logic into the test files.
I will work on it separately. For now it should be OK.

prsunny

Sorry that I couldn't post the comment earlier.

prsunny · 2021-09-15T02:21:30Z

scripts/db_migrator.py

@@ -371,6 +371,16 @@ def prepare_dynamic_buffer_for_warm_reboot(self, buffer_pools=None, buffer_profi

        return True

+    def migrate_config_db_port_table_for_auto_neg(self):


We don't need this changes in db_migrator

prsunny · 2021-09-15T02:22:48Z

tests/db_migrator_test.py

@@ -196,7 +197,7 @@ def test_mellanox_buffer_migrator_negative_nondefault_for_warm_reboot(self):
        self.mellanox_buffer_migrator_warm_reboot_runner(input_config_db, input_appl_db, expected_config_db, expected_appl_db, False)


-class TestInitConfigMigrator(object):
+class TestAutoNegMigrator(object):


Please remove this test and changes

…1823) * [sonic-utilities]remove db_migrator logic for autoneg What I did This PR removes all the logic for db_migrator which went into #1817 , This is required because this will cause changing the logic to "0/1" to "on/off" in swss and cause a problem in upgrade. How I did it How to verify it autoneg enable/disable works with the implementation. Removing the db_migration logic so no check required Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

* 2a8957d 2021-09-14 | [202012][sonic-utilities] CLI support for port auto negotiation (sonic-net#1817) (HEAD, origin/202012) [vdahiya12] Signed-off-by: Guohan Lu <lguohan@gmail.com>

vdahiya12 requested review from Junchao-Mellanox, prsunny and theasianpianist September 13, 2021 23:36

prsunny approved these changes Sep 14, 2021

View reviewed changes

vdahiya12 added 2 commits September 14, 2021 05:31

fix LGTM

db16a87

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

go back to imports

6297d51

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 marked this pull request as draft September 14, 2021 14:12

lguohan reviewed Sep 14, 2021

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

lguohan reviewed Sep 14, 2021

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

lguohan reviewed Sep 14, 2021

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

remove commands which are not supported

d425dd4

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

fix unit

7cc0b39

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 added 2 commits September 14, 2021 21:00

Merge branch 'auto_change' of https://github.com/vdahiya12/sonic-util…

a57d5c1

…ities into 202012

fix command reference

6127d34

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

fix the testing change;correct param

7ef0c31

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 marked this pull request as ready for review September 14, 2021 23:14

fix unit with reinterpret

65e2bb8

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 changed the title ~~[sonic-utilities] CLI support for port auto negotiation~~ [202012][sonic-utilities] CLI support for port auto negotiation Sep 14, 2021

lguohan approved these changes Sep 15, 2021

View reviewed changes

lguohan merged commit 2a8957d into sonic-net:202012 Sep 15, 2021

prsunny reviewed Sep 15, 2021

View reviewed changes

vdahiya12 mentioned this pull request Sep 16, 2021

[sonic-utilities]remove db_migrator logic for autoneg enable/disable #1823

Merged

vdahiya12 deleted the auto_change branch October 20, 2021 21:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[202012][sonic-utilities] CLI support for port auto negotiation #1817

[202012][sonic-utilities] CLI support for port auto negotiation #1817

vdahiya12 commented Sep 13, 2021 •

edited

Loading

lgtm-com bot commented Sep 13, 2021

lgtm-com bot commented Sep 14, 2021

liat-grozovik commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lguohan commented Sep 15, 2021 •

edited

Loading

vdahiya12 commented Sep 15, 2021

prsunny left a comment

prsunny Sep 15, 2021

prsunny Sep 15, 2021

		@@ -371,6 +371,16 @@ def prepare_dynamic_buffer_for_warm_reboot(self, buffer_pools=None, buffer_profi

		return True

		def migrate_config_db_port_table_for_auto_neg(self):

[202012][sonic-utilities] CLI support for port auto negotiation #1817

[202012][sonic-utilities] CLI support for port auto negotiation #1817

Conversation

vdahiya12 commented Sep 13, 2021 • edited Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

lgtm-com bot commented Sep 13, 2021

lgtm-com bot commented Sep 14, 2021

liat-grozovik commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

lguohan commented Sep 15, 2021 • edited Loading

vdahiya12 commented Sep 15, 2021

prsunny left a comment

Choose a reason for hiding this comment

prsunny Sep 15, 2021

Choose a reason for hiding this comment

prsunny Sep 15, 2021

Choose a reason for hiding this comment

vdahiya12 commented Sep 13, 2021 •

edited

Loading

lguohan commented Sep 15, 2021 •

edited

Loading