[Logrotate] Add config and show commands #3293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastiuk
force-pushed
the
dev-logrotate-config
branch
from
7bf2f08 to
e6aafd4
Compare
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
fastiuk
force-pushed
the
dev-logrotate-config
branch
from
e6aafd4 to
5f4431e
Compare
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
|
@dgsudharsan could you please help to review? |
|
@fastiuk the command reference guide should be updated with the CLI changes in the same PR |
dgsudharsan
suggested changes
Jul 10, 2024
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
|
Tests will fail until sonic-net/sonic-swss-common#783 is merged |
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
|
Tests will fail until sonic-net/sonic-swss-common#783 is merged |
maipbui
reviewed
Oct 7, 2024
maipbui
reviewed
Oct 7, 2024
maipbui
reviewed
Oct 7, 2024
maipbui
reviewed
Oct 7, 2024
maipbui
reviewed
Oct 7, 2024
saiarcot895
reviewed
Nov 10, 2024
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
|
@saiarcot895 please merge if you can, CI passed here |
saiarcot895
approved these changes
Jan 11, 2025
|
@saiarcot895 many thanks. Please merge as well if you have rights for that |
|
@liat-grozovik could you please merge this PR? All checkers are passed, and it is approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends-on #783
What I did
Added CLI commands for Banner feature according to HLD: TBD
How I did it
Added CLI commands to:
How to verify it
Manual testing
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)