[Logrotate] Add logrotate feature HLD #1683
Conversation
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
fastiuk
force-pushed
the
dev-logrotate-config
branch
from
f6d8a33
to
af5b905
Compare
fastiuk
changed the title
|
HLD is reviewed in community on 5/14/2024 |
|
call for reviewers, please leave your comments if you want to be a reviewer of this HLD. Thanks. |
| It reads log rotate configuration from database and apply it to log rotate config files. | ||
|
|
||
|
|
||
| **The log rotate config files will be used:** |
There was a problem hiding this comment.
what is the default log rotation configuration?
| **The log rotate config files will be used:** | ||
| 1. /etc/logrotate.d/rsyslog - generic log files | ||
| 2. /etc/logrotate.d/debug - debug log files | ||
| 3. /etc/logrotate.d/syslog - syslog files |
There was a problem hiding this comment.
Mentioning the contents of these files would be helpful.
There was a problem hiding this comment.
Additionally, while syslog is obvious, what files fall under debug log files? What about generic log files?
|
|
||
| **User interface**: | ||
| ``` | ||
| config |
There was a problem hiding this comment.
We should be able to revert back the default value
|
|
||
|
|
||
| **The log rotate config files will be used:** | ||
| 1. /etc/logrotate.d/rsyslog - generic log files |
There was a problem hiding this comment.
Clarify the content and maybe change the name for an old file
|
community review recording https://zoom.us/rec/share/pxggDmJPYuO2cbCd3OALS8z-rce-qXfZ_-zX6AU7s1xWyIi2oSiw8eJJ_rBU0PMW.wlH1D2euCp9OJ-vS |
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
|
@saiarcot895 could you review? |
|
we need to expedite this review. the PRs are ready for more than 3 months |
|
@liat-grozovik can we merge this? No further comments were provided. |
| #### 2.3.1 Config command group | ||
| **The following command set log rotate disc percentage:** | ||
| ```bash | ||
| config logrotate <syslog|debug> disk-percentage <disk-percentage> |
There was a problem hiding this comment.
Above, there are three categories of files: syslog, debug, and rsyslog. But there are only two here. Is rsyslog non-configurable?
There was a problem hiding this comment.
No, it is not. It holds generic configuration, but files "syslog" and "debug" hold configuration per those files. So we can rotate those files only.
doc/logrotate/logrotate_hld.md
Outdated
| file disk-percentage frequency max-number size | ||
| ------ ----------------- ----------- ------------ ------ | ||
| syslog 10.2 daily 10 20.0 | ||
| debug 50.5 weekly 20 10.0 |
There was a problem hiding this comment.
For the size column, please make it clear that this is mebibytes.
There was a problem hiding this comment.
Make sense, updated
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
|
@saiarcot895 all comments were addressed, can I get an approval? |
This document provides general information about log rotate implementation in SONiC
The scope of this document is to cover definition, design and implementation of SONiC log rotate feature and related CLI.