Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logrotate] Update log rotate configuration via ConfigDB #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fastiuk
Copy link
Contributor

@fastiuk fastiuk commented May 17, 2023

This PR brings functionality that allows us to update the log rotation configs by writing to the LOGGING table of ConfigDB

@fastiuk
Copy link
Contributor Author

fastiuk commented May 17, 2023

Tests will fail until sonic-net/sonic-swss-common#783 will be merged

@fastiuk fastiuk requested a review from dgsudharsan May 17, 2023 15:18
Copy link
Contributor

@dgsudharsan dgsudharsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add UT for these changes

@fastiuk
Copy link
Contributor Author

fastiuk commented Jun 2, 2023

/azpw run sonic-net.sonic-host-services

@mssonicbld
Copy link

/AzurePipelines run sonic-net.sonic-host-services

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maipbui
Copy link
Contributor

maipbui commented Jun 29, 2023

@fastiuk Please merge latest master code to trigger Semgrep.

fastiuk and others added 2 commits December 18, 2023 16:17
* Handle changes in LOGGING table

Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
@liat-grozovik
Copy link
Collaborator

@dgsudharsan any further comments?
@fastiuk please handle build failures and ensure checkers are passing

scripts/hostcfgd Show resolved Hide resolved
@fastiuk
Copy link
Contributor Author

fastiuk commented Aug 14, 2024

Tests will fail until sonic-net/sonic-swss-common#783 will be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants