Removing /SourceFile: parameter from DriftReport arguments #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshFieldstad
requested review from
zijchen,
dzsquared and
yorek
as code owners
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
zijchen
reviewed
Feb 21, 2023
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
requested review from
zijchen
and removed request for
yorek and
dzsquared
zijchen
approved these changes
Feb 21, 2023
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
|
@microsoft-github-policy-service agree |
|
@zijchen FYI I am doing some testing on my side and after reviewing old PR's discovered that main.js needed to be recompiled when updating *.ts files. I ran and committed the result, if needed I am happy to revert this change or redo it using proper process. Thank you! |
|
@JoshFieldstad - it looks like you will need to resolve the conflict on main.js (either revert the build or pull in the previous changes from the default branch) |
This reverts commit 94302a6.
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
JoshFieldstad
had a problem deploying
to
Automation test
GitHub Actions
Failure
|
@dzsquared I reverted the change to main.js. What do you need from me on that main.js? Should I just leave it alone and let a pipeline or other process update it? Or is there something I should do? Thanks! |
|
@JoshFieldstad - usually you'd need to build main.js after having pulled in any recent changes from the default branch (it just so happens I merged to master this morning while you were working on this) - but I'm about to do a release and will open another PR with main.js built and some docs changes so no need for you to worry about it today :) |
|
@dzsquared Thank you sir! |
dzsquared
added a commit
that referenced
this pull request
Feb 22, 2023
* add tests for #167 * docs update * run build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.