Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for build and publish database project #65

Merged
merged 23 commits into from
Feb 23, 2022
Merged

Add support for build and publish database project #65

merged 23 commits into from
Feb 23, 2022

Conversation

zijchen
Copy link
Contributor

@zijchen zijchen commented Jan 5, 2022

Introducing 2 new inputs to this action:

  • project-file - Path to a database project (.sqlproj) file. Project must use the Microsoft.Build.Sql SDK
  • build-arguments - Additional arguments supplied to building the sqlproj with dotnet build

The sqlproj will be first built with dotnet build <project-file> -p:NetCoreBuild=true <build-arguments>. The output DACPAC file will then be published using existing SqlPackage logic from the DACPAC action.

  • This means the workflow runner needs to have both dotnet and SqlPackage installed (only for self-hosted runners, default ones have these pre-installed).
  • The current arguments input can still be used to specify additional SqlPackage parameters. We may want to rename this in the future to better distinguish between that and build-arguments. New features in this PR are intended to be fully backwards-compatible.

Added new tests to cover project build functionality. Also added a step to the pr-check.yml to test project build and publish a test sqlproj to Azure.

@zijchen zijchen temporarily deployed to Automation test January 5, 2022 21:43 Inactive
@zijchen zijchen temporarily deployed to Automation test January 5, 2022 21:43 Inactive
src/AzureSqlAction.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jan 21, 2022
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 22:29 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 22:29 Inactive
action.yml Show resolved Hide resolved
src/DotnetUtils.ts Outdated Show resolved Hide resolved
__tests__/DotnetUtils.test.ts Show resolved Hide resolved
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:16 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:16 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:16 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:30 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:30 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:36 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:36 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:44 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:44 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:44 Inactive
@zijchen zijchen temporarily deployed to Automation test February 22, 2022 23:44 Inactive
@zijchen zijchen temporarily deployed to Automation test February 23, 2022 01:03 Inactive
@zijchen zijchen temporarily deployed to Automation test February 23, 2022 01:03 Inactive
@zijchen zijchen temporarily deployed to Automation test February 23, 2022 01:03 Inactive
@zijchen zijchen temporarily deployed to Automation test February 23, 2022 01:03 Inactive
@zijchen zijchen merged commit 1c1b76b into master Feb 23, 2022
@zijchen zijchen deleted the sqlproj branch June 21, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants