Add custom type validator to support x-ms-mutability #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amarzavery if you can have a look. Tested in oav and all is good. I think the only question is if we want to introduce an extra error if read is missing in x-ms-mutability but still a property is present. If you think so I can open an issue for that. |
amarzavery
reviewed
May 18, 2018
| @@ -63,5 +63,56 @@ function requiredPropertyValidator (report, schema, json) { | |||
| } | |||
| } | |||
|
|
|||
| function typeValidator (report, schema, json) { | |||
There was a problem hiding this comment.
looks good to me. indentation 2 spaces.
I am not sure if we want to do this for request objects. For response, yes raising an error would be the right thing to do. |
vladbarosan
force-pushed
the
addTypeCustomValidator
branch
from
a059476 to
edc4e42
Compare
|
@amarzavery yes this would be strictly for responses . Opened an issue here: Azure/oav#250 |
|
Feel free to merge once the CI passes. |
|
Fixes Azure/oav#239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type validator was in previous z-schema versions extracted out of validators to enable fast failure for that specific failure since it was the most common.
This has been achieved in a different way in 3.22.0 and now the type validator is part of the validators so we can overwrite it.