Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch dns #423

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Patch dns #423

merged 3 commits into from
Jul 6, 2022

Conversation

krowlandson
Copy link
Contributor

Overview/Summary

This PR includes changes to the following regional DNS zones as requested in #412:

  • azure_backup
  • azure_site_recovery

It also includes a spelling update in the Wiki docs from UK English to US English for consistency within docs.

This PR fixes/adds/changes/removes

  1. Fixes Feature Request - Private DNS Zone logic needs changed for a select few zones #412

Breaking Changes

n/a

Testing Evidence

Changes visible in git diff for the baseline_values.json file:

git diff showing changes made to regional DNS zones

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

Kevin Rowlandson added 2 commits July 6, 2022 12:47
- azure_backup
- azure_site_recovery
@krowlandson krowlandson added the bug Something isn't working label Jul 6, 2022
@krowlandson krowlandson added this to the v2.2.0 milestone Jul 6, 2022
@krowlandson krowlandson self-assigned this Jul 6, 2022
@krowlandson
Copy link
Contributor Author

/azp run update

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment

modules/connectivity/locals.geo_codes.tf.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Private DNS Zone logic needs changed for a select few zones
3 participants